Open
Conversation
follow the mpl pattern and raise a user-visible warning on calling a deprecated function. Also follow mpl pattern and give function 1 minor version to be deprecated before being removed.
danielballan
force-pushed
the
reinstate-logging
branch
from
635aacd to
3248a72
Compare
Author
|
bump on this thread. I suspect some of this may have been re-done. |
danielballan
force-pushed
the
reinstate-logging
branch
from
3248a72 to
5b07749
Compare
danielballan
force-pushed
the
reinstate-logging
branch
2 times, most recently
from
fe03670 to
7b2f1bc
Compare
danielballan
force-pushed
the
reinstate-logging
branch
from
347baff to
d248b84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few minor changes, fully removes use of
print_update