Development#101
Conversation
…tire queue to hang. Added methods to reap stale InProgress items and reset queue items to Pending.
…into development
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba1458db29
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| public async Task ResetQueueItemToPendingAsync(Guid id, CancellationToken stoppingToken) | ||
| { | ||
| var queueItem = await DbContext.QueueItems.FindAsync([id, stoppingToken], stoppingToken); |
There was a problem hiding this comment.
Pass only queue item ID into FindAsync
ResetQueueItemToPendingAsync calls FindAsync([id, stoppingToken], stoppingToken), which sends two key values (id plus the cancellation token) while QueueItemEntity only has a single primary key (Id), so EF throws instead of loading the row. In the new increment-failure recovery path this makes the immediate reset-to-pending step fail every time, leaving items stuck in InProgress until the periodic reaper eventually fixes them.
Useful? React with 👍 / 👎.
No description provided.