Skip to content

Development#101

Merged
dangerworm merged 3 commits into
mainfrom
development
Apr 28, 2026
Merged

Development#101
dangerworm merged 3 commits into
mainfrom
development

Conversation

@dangerworm
Copy link
Copy Markdown
Owner

No description provided.

dangerworm and others added 3 commits April 28, 2026 18:24
…tire queue to hang.

Added methods to reap stale InProgress items and reset queue items to Pending.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ba1458db29

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


public async Task ResetQueueItemToPendingAsync(Guid id, CancellationToken stoppingToken)
{
var queueItem = await DbContext.QueueItems.FindAsync([id, stoppingToken], stoppingToken);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Pass only queue item ID into FindAsync

ResetQueueItemToPendingAsync calls FindAsync([id, stoppingToken], stoppingToken), which sends two key values (id plus the cancellation token) while QueueItemEntity only has a single primary key (Id), so EF throws instead of loading the row. In the new increment-failure recovery path this makes the immediate reset-to-pending step fail every time, leaving items stuck in InProgress until the periodic reaper eventually fixes them.

Useful? React with 👍 / 👎.

@dangerworm dangerworm merged commit ce77e2c into main Apr 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant