Conversation
aweli
commented
Mar 9, 2019
aweli
commented
- redis.conf can only be edited as root
- fix node path
- add emphasis on opening port on the router as well
- simplify editing of ufw
dangeross
requested changes
Mar 11, 2019
Owner
dangeross
left a comment
dangeross
left a comment
There was a problem hiding this comment.
Thanks for the pull request @awerffeli, I've made some comments below
| $ tar -xf node-v10.15.1-linux-armv7l.tar.xz | ||
| $ sudo mkdir /usr/local/lib/nodejs/node-v10.15.1 | ||
| $ mv node-v10.15.1-linux-armv7l.tar.xz/* /usr/local/lib/nodejs/node-v10.15.1 | ||
| $ sudo tar -xf node-v10.15.1-linux-armv7l.tar.xz -C /usr/local/lib/nodejs/node-v10.15.1 |
Owner
There was a problem hiding this comment.
Should remove this line, as a secondary extract of the tar file to /usr/local/lib/nodejs/node-v10.15.1 is no longer needed
| $ ufw reload | ||
| $ sudo ufw allow 3000 comment 'allow LndHub' | ||
| $ sudo ufw reload | ||
| $ exit |
Owner
There was a problem hiding this comment.
Can remove, if we're not doing the sudo su
|
aweli:patch-1 |
|
Listo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.