Skip to content

Tuple to single value traits#1846

Merged
nfahlgren merged 5 commits intov5.0from
tuple-to-single-value-traits
Feb 19, 2026
Merged

Tuple to single value traits#1846
nfahlgren merged 5 commits intov5.0from
tuple-to-single-value-traits

Conversation

@joshqsumner
Copy link
Copy Markdown
Contributor

@joshqsumner joshqsumner commented Nov 25, 2025

Describe your changes
Outputs ellipse_center and center_of_mass as single _x and _y traits instead of tuples.

Type of update
Is this a feature update.

Associated issues
Closes #1666

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@joshqsumner joshqsumner added this to the PlantCV v5.0 milestone Nov 25, 2025
@joshqsumner joshqsumner added work in progress Mark work in progress update Updates an existing feature/method labels Nov 25, 2025
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Nov 25, 2025

DeepSource Code Review

DeepSource reviewed changes in the commit range c5454ac...386f4be on this pull request. Below is the summary for the review, and you can see the individual issues we found as review comments.

For detailed review results, please see the PR on DeepSource ↗

PR Report Card

Security × 0 issues Overall PR Quality   

Reliability × 0 issues
Complexity × 0 issues
Hygiene × 0 issues
Coverage × 0 issues

Code Review Summary

Analyzer Status Summary Details
Python No new issues detected. Review ↗
Test coverage No new issues detected. Review ↗
How are these analyzer statuses calculated?

Administrators can configure which issue categories are reported and cause analysis to be marked as failed when detected. This helps prevent bad and insecure code from being introduced in the codebase. If you're an administrator, you can modify this in the repository's settings.

Code Coverage Summary

Language Line Coverage Branch Coverage
New Code Overall New Code Overall
Aggregate
100%
[✓ above threshold]
100%
100%
100%
Python
100%
[✓ above threshold]
100%
100%
100%

➟ Additional coverage metrics may have been reported. See full coverage report ↗

@joshqsumner joshqsumner changed the base branch from main to v5.0 November 25, 2025 14:40
@joshqsumner joshqsumner added ready to review and removed work in progress Mark work in progress labels Nov 25, 2025
@HaleySchuhl
Copy link
Copy Markdown
Contributor

Feel free to disagree, what if tuples were output in both CSVs (for backwards compatibility with statistical workflows downstream)?

@nfahlgren nfahlgren merged commit d0f4fee into v5.0 Feb 19, 2026
5 checks passed
@nfahlgren nfahlgren deleted the tuple-to-single-value-traits branch February 19, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to review update Updates an existing feature/method

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update tuple outputs so they will be treated as single-value traits

3 participants