Skip to content

Rename filepath to dir#1840

Merged
nfahlgren merged 9 commits intov5.0from
rename-filepath-to-dir
Feb 17, 2026
Merged

Rename filepath to dir#1840
nfahlgren merged 9 commits intov5.0from
rename-filepath-to-dir

Conversation

@joshqsumner
Copy link
Copy Markdown
Contributor

@joshqsumner joshqsumner commented Nov 5, 2025

Describe your changes
Renamed created columns for relpath from config.input_dir from filepath1:N to dir1:N in parallel.parsers.parse_filepath.

Type of update
This is a feature update.

Associated issues
None

Additional context
Also addresses a bug that I think I introduced with the metadata regex stuff as a deepsource fix somewhere along the way related to which pieces of the relpath are used, it was skipping the first one but I think a syntax change upstream made that the wrong thing to do. Might be evidence that it needs more specific tests.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@joshqsumner joshqsumner added bugfix Bug fixes work in progress Mark work in progress update Updates an existing feature/method merge in order Set of PRs that need to be merged sequentially labels Nov 5, 2025
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Nov 5, 2025

DeepSource Code Review

DeepSource reviewed changes in the commit range 93599a2..25f1d51 on this pull request. Below is the summary for the review, and you can see the individual issues we found as review comments.

For detailed review results, please see the PR on DeepSource ↗

PR Report Card

Security × 0 issues Overall PR Quality   

Reliability × 0 issues
Complexity × 0 issues
Hygiene × 0 issues
Coverage × 0 issues

Code Review Summary

Analyzer Status Summary Details
Python No new issues detected. Review ↗
Test coverage No new issues detected. Review ↗
How are these analyzer statuses calculated?

Administrators can configure which issue categories are reported and cause analysis to be marked as failed when detected. This helps prevent bad and insecure code from being introduced in the codebase. If you're an administrator, you can modify this in the repository's settings.

Code Coverage Summary

Language Line Coverage Branch Coverage
New Code Overall New Code Overall
Aggregate
100%
[✓ above threshold]
100%
100%
100%
Python
100%
[✓ above threshold]
100%
100%
100%

➟ Additional coverage metrics may have been reported. See full coverage report ↗

@joshqsumner joshqsumner added ready to review and removed work in progress Mark work in progress labels Nov 5, 2025
@nfahlgren nfahlgren added this to the PlantCV v5.0 milestone Feb 17, 2026
@nfahlgren nfahlgren merged commit 49b3f70 into v5.0 Feb 17, 2026
5 checks passed
@nfahlgren nfahlgren deleted the rename-filepath-to-dir branch February 17, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fixes merge in order Set of PRs that need to be merged sequentially ready to review update Updates an existing feature/method

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants