Test against vendored dandiapi other than default #1771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## remove-hardcode #1771 +/- ##
================================================
Coverage 75.07% 75.07%
================================================
Files 84 84
Lines 11910 11910
================================================
Hits 8942 8942
Misses 2968 2968
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Configuer CI to test against a vendor specific DANDI API other than the default instance of DANDI API
candleindark
force-pushed
the
test-against-vendored-dandiapi
branch
from
5041803 to
f92fda7
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
3 tasks
Closed
2 tasks
yarikoptic
pushed a commit
that referenced
this pull request
Dec 15, 2025
* test: update `test_update_dandiset_from_doi` So that the checks of `id` and `identifier` in metadata allow different instance names * test: update `test_download_dandiset_yaml` So that the check of `id` in metadata allows different instance names * feat: remove block that fetch dandiset identifier that is irrelevant See #1760 (comment) for details * doc: replace hardcoded "DANDI:" comment To reflect that instance names are no longer restricted to "DANDI" * fix: strip instance name prefix from dandiset ID in `update_dandiset_from_doi` This is only a replacement for the code that strips the "DANDI:" prefix. The replacement works for dandisets of different DANDI instances. However, `update_dandiset_from_doi` is far from robust. This replacement doesn't fix underlying weakness stems from assumptions. Further improvements of `update_dandiset_from_doi` are needed. * Reimplement `dandi.utils.is_url` (#1767) * feat: reimplement `dandi.utils.is_url` So that it can determine whether a given string is a standard HTTP, HTTPS, FTP URL, or DANDI URL more precisely. Additionally, this solution supports DANDI URL of different DANDI archive instances. * test: Add tests for `dandi.utils.is_url` * ci: test against vendored dandiapi other than default (#1771) Configuer CI to test against a vendor specific DANDI API other than the default instance of DANDI API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit message for details.