Skip to content

Not run test without obolibrary mark in obolibrary-only env #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
candleindark merged 1 commit into from
Dec 15, 2025
Merged

Not run test without obolibrary mark in obolibrary-only env #1770

candleindark merged 1 commit into from
Dec 15, 2025

Conversation

@candleindark
Copy link
Member

@candleindark candleindark commented Dec 15, 2025

See individual commit message for detail.

@candleindark
ci(fix): not run test without obolibrary mark in obolibrary-only env
c4287b5 
Correct GH workflow to not run any
test without the `obolibrary` mark in
the `obolibrary-only` GH CI environment
@candleindark candleindark requested a review from Copilot December 15, 2025 18:08
Copilot AI reviewed Dec 15, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents tests without the obolibrary mark from running in the obolibrary-only test environment by adding an additional condition to the workflow step.

Key Changes:

  • Modified the test execution condition to exclude the obolibrary-only mode from running tests marked as "not obolibrary"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@candleindark candleindark added the tests Add or improve existing tests label Dec 15, 2025
@codecov
Copy link

codecov bot commented Dec 15, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.02%. Comparing base (3501190) to head (c4287b5).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1770      +/-   ##
==========================================
- Coverage   75.03%   75.02%   -0.01%     
==========================================
  Files          84       84              
  Lines       11889    11889              
==========================================
- Hits         8921     8920       -1     
- Misses       2968     2969       +1
Flag Coverage Δ
unittests 75.02% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yarikoptic
Copy link
Member

yarikoptic commented Dec 15, 2025

@CodyCBakerPhD please have a look since I think you introduced splitting originally

@CodyCBakerPhD CodyCBakerPhD removed their request for review December 15, 2025 20:46
@candleindark candleindark merged commit 303f941 into master Dec 15, 2025
35 of 38 checks passed
@candleindark candleindark deleted the obolibrary-only-ci-env branch December 15, 2025 22:39
@github-actions
Copy link

github-actions bot commented Dec 17, 2025

🚀 PR was released in 0.74.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@CodyCBakerPhD CodyCBakerPhD CodyCBakerPhD approved these changes

@yarikoptic yarikoptic Awaiting requested review from yarikoptic

Assignees

No one assigned

Labels

released tests Add or improve existing tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@candleindark @yarikoptic @CodyCBakerPhD