add_nfactor#25
Open
hvds wants to merge 2 commits intodanaj:masterfrom
Open
Conversation
Owner
|
I intentionally left the poly data out of the MANIFEST, as it would double the size of the distribution. I would like to see the class polynomials compressed or better yet efficiently generated, but I don't see that happening soon. I like the change to add_factor. |
Author
Ok, I added it only because I saw a complaint during
Cool, let me know if you'd like me to repush without the MANIFEST change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Dana, not sure if you would want this change, it modifies
add_factorto take a count.I'd expect it to give a slight improvement for random numbers, but nothing huge. I think it also reduces complexity slightly, since there are several points in the code where you have to
ADD_FACTORiteratively.