Skip to content

bump v2.00rc#72

Closed
damachine wants to merge 211 commits intov2.00rcfrom
main
Closed

bump v2.00rc#72
damachine wants to merge 211 commits intov2.00rcfrom
main

Conversation

@damachine
Copy link
Owner

@damachine damachine commented Sep 24, 2025

Pull Request

🎯 Specialized Templates Available

📝 Description

🔄 Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that changes existing functionality)
  • 📚 Documentation update (documentation)
  • 🎨 Code style/formatting (no functional changes)
  • ♻️ Refactoring (code change without fix/feature)
  • ⚡ Performance improvement
  • 🧪 Test update

🧪 How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Testing
  • Tested on target hardware (AIO cooler)

Test Configuration:

  • Compiler version:
  • OS:
  • Hardware:

📋 Checklist

  • Code follows project style guidelines
  • Self-review of code performed
  • Code is commented, especially in hard-to-understand areas
  • Corresponding documentation has been updated
  • Changes generate no new warnings
  • Unit tests have been added/updated
  • New and existing tests pass locally
  • Dependent changes have been merged and published

🔗 Related Issues

Fixes #(issue number)
Closes #(issue number)
Related to #(issue number)

📸 Screenshots (if UI changes)

📚 Additional Notes

🎯 Codacy Analysis

  • Codacy analysis without new issues
  • All found issues have been fixed

For Maintainers:

  • Code review performed
  • Tests pass
  • Documentation updated
  • Ready to merge

@damachine
README
6896de1 
-AUR should be work again
@damachine
bump to version 1.32
5b6bf8b
@damachine
README
4b77917
@damachine
instructions
560a427
@damachine
feat: comprehensive security hardening and buffer overflow protection
a9fdf1f 
- Replace unsafe string functions (strncpy, strcpy) with cc_safe_strcpy
- Remove impossible NULL checks on fixed-size array members (compiler warnings)
- Strengthen JSON input validation with early null/empty checks
- Add comprehensive error handling and input validation throughout
- Improve PID file management with atomic writes and proper cleanup

All Codacy security findings resolved while maintaining functionality.
@damachine
All Codacy security findings resolved while maintaining functionality.
cfda4b0
@damachine
bump version to 1.33
39602c6
@damachine
fix: include project headers in .h files
9d04cc6 
-cppcheck-suppress missingInclude
@damachine
bump version to 1.34
04e2f79 
- fix some cppcheck warnings
- add code quality tools to CI
@damachine
bump version to 1.35
876f270
@damachine
bump version to 1.36
069dd0a
@damachine
workflows
be76ebe
@damachine
fix: cppcheck missingIncludeSystem massage
b1001a2
@damachine
bump version to 1.37
0129bb1
@damachine
bump version to 1.38
fccfe27
@damachine
bump version to 1.39
97bba61
@damachine
refactor: eliminate code duplication in display.c temperature bar ren…
8fdb95a 
…dering

- Extract duplicated cairo_arc calls into reusable draw_rounded_rectangle_path() helper function
- Replace duplicate code blocks at lines 149-157 and 192-202 with function calls
- Maintain existing functionality for both background and border rendering
- Improve code maintainability by following DRY principle
- Add proper Doxygen documentation for new helper function

Resolves Codacy duplication warning for rounded rectangle path creation.
@damachine
refactor: eliminate JSON device type extraction duplication
97e453d 
- Extract common JSON device type parsing logic into reusable extract_device_type_from_json() helper function
- Replace duplicate code blocks in coolercontrol.c (lines 155-165) and monitor.c (lines 72-81)
- Add function declaration to coolercontrol.h header
- Add jansson.h include to coolercontrol.h for json_t type support
- Maintain existing functionality while improving code maintainability
- Follow DRY principle by centralizing JSON device type extraction logic

Resolves Codacy duplication warning for JSON device iteration pattern.
@damachine
bump: version to 1.40
5f3d16d
@damachine
refactor: dramatically reduce cyclomatic complexity in config.c
5723795
@damachine
refactor: massive cyclomatic complexity reduction in config.c
08a379a 
- Replace all if-else chains with early returns in config parsing functions
- Reduce get_paths_config() complexity by consolidating null checks
- Optimize get_display_config() with helper function for orientation validation
- Streamline get_layout_config() using early returns pattern
- Simplify get_font_config() and get_temperature_config() with early exits
- Refactor get_color_pointer_from_section() eliminating else-if chains
- Optimize set_color_component() with early return pattern
- Add input validation helper functions to reduce nested conditions

Expected complexity reduction from 159 to <50 total complexity score.
Functions now follow single responsibility principle with <10 complexity each.
@damachine
refactor: massive cyclomatic complexity reduction in config.c
339ba45
@damachine
"refactor: optimize set_color_defaults() with lookup table
56205b4 
- Replace 8 separate if-blocks with data-driven approach
- Reduce cyclomatic complexity from 154 to target <50
- Use ColorDefault struct for cleaner code organization
- Maintain same functionality with improved maintainability
@damachine
refactor: optimize complexity of cooler control logic
b347ac7
@damachine
refactor: reduce display.c complexity
a3063b8
@damachine
fix: revert display.c changes
e96118f
@damachine
bump version to 1.41
c4827f7
@damachine
README
5d487f5
@damachine
refactor: temperature display vertical adjustment constants
49199ce
@damachine
workflows
a560887
@damachine
docs: fix typo in README
98cc81e
@damachine
bump VERSION to 1.72
2ca00b0
@damachine
Update feature description in README.md
72267f2
@damachine
Merge pull request #55 from damachine/damachine-patch-1
07cbf64 
Update feature description in README.md
@damachine
bump version to 1.73
0261a36
@damachine
Merge branch 'main' of https://github.com/damachine/coolerdash
d1b8270
@damachine
Revise contribution and help section in README (#56)
0b506b7 
Updated contribution and support links in README.

Signed-off-by: damachine <christkue79@gmail.com>
@damachine
Enhance contribution and help section in README (#57)
70bd221 
Signed-off-by: damachine <christkue79@gmail.com>
@damachine
Fix link formatting in README.md (#58)
44c267d 
Signed-off-by: damachine <christkue79@gmail.com>
@damachine
Enhance README with contribution tips and links (#59)
ccc0b11 
Added a contribution tip and links for discussions and issues.

Signed-off-by: damachine <christkue79@gmail.com>
@damachine
bump version to 1.74
7f4af41
@damachine
Update README.md (#60)
820a892 
Signed-off-by: damachine <christkue79@gmail.com>
@damachine
Update installation steps in README.md (#61)
3fb5f3d 
Signed-off-by: damachine <christkue79@gmail.com>
@damachine
Update README.md badges and installation instructions (#62)
157ed8b 
Removed several badge links and added new installation badges for AUR and manual installation.

Signed-off-by: damachine <christkue79@gmail.com>
@damachine
Revise notes and section headers in README (#63)
3563c9d 
Signed-off-by: damachine <christkue79@gmail.com>
@damachine
Fix badge link for Linux platform in README (#64)
6641ab8 
Signed-off-by: damachine <christkue79@gmail.com>
@damachine
Enhance README with common issues and solutions (#65)
572e9d8 
Added warnings and tips for common issues related to CoolerDash and CoolerControl.

Signed-off-by: damachine <christkue79@gmail.com>
@damachine
Fix rm command syntax in README (#66)
c2fcd48 
Signed-off-by: damachine <christkue79@gmail.com>
@damachine
Simplify warning section in README (#67)
6da1c56 
Removed unnecessary 'Solution' header from warning section.

Signed-off-by: damachine <christkue79@gmail.com>
@damachine
Fix formatting for CoolerDash and CoolerControl sections (#68)
f27d609 
Signed-off-by: damachine <christkue79@gmail.com>
@damachine
Remove warranty disclaimer from README (#69)
b689205 
Removed warranty disclaimer from README.

Signed-off-by: damachine <christkue79@gmail.com>
@damachine
Update README.md (#70)
660a840 
Signed-off-by: damachine <christkue79@gmail.com>
@damachine
Update README for CoolerDash enable/start instructions
170afce 
Signed-off-by: damachine <christkue79@gmail.com>
@damachine
Update README for CoolerDash autostart instructions
ab93360 
Signed-off-by: damachine <christkue79@gmail.com>
@damachine
Remove 'src/' from .gitignore
61d8cbc 
Signed-off-by: damachine <christkue79@gmail.com>
@damachine
refactor: update .gitignore. exclude .cache and .makepkg in .codacy.yml
da789e1
@damachine
Fix formatting in AUR installation instructions (#71)
c3a66d3 
Signed-off-by: damachine <christkue79@gmail.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 24, 2025
View reviewed changes
src/config.c
va_list args;
va_start(args, format);
vfprintf(output, format, args);
vsnprintf(msg_buf, sizeof(msg_buf), (format ? format : "(null)"), args);

Check warning

Code scanning / Flawfinder (reported by Codacy)

If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. Warning

If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification.
src/main.c
FILE *f = fopen(temp_file, "w");
if (!f) {
// Open with specific permissions to avoid race condition
int fd = open(temp_file, O_WRONLY | O_CREAT | O_EXCL, 0644);

Check warning

Code scanning / Flawfinder (reported by Codacy)

Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). Warning

Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362).
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 24, 2025
View reviewed changes
src/config.c
if (config->lcd_brightness == 0)
config->lcd_brightness = 80;
if (config->lcd_orientation == 0)
config->lcd_orientation = 0;

Check warning

Code scanning / Cppcheck (reported by Codacy)

Assignment 'config->lcd_orientation=0' is redundant with condition 'config->lcd_orientation==0'. Warning

Assignment 'config->lcd_orientation=0' is redundant with condition 'config->lcd_orientation==0'.
src/coolercontrol.c
* @details Common helper function to extract device type string from JSON device object. Returns NULL if extraction fails.
*/
const char* extract_device_type_from_json(json_t *dev) {
if (!dev) return NULL;

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 15.6 rule Note

MISRA 15.6 rule
src/display.c
{
const double radius = 8.0;
cairo_new_sub_path(cr);
cairo_arc(cr, x + width - radius, y + radius, radius, -DISPLAY_M_PI_2, 0);

Check warning

Code scanning / Cppcheck (reported by Codacy)

Skipping configuration 'M_PI_2' since the value of 'M_PI_2' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. Warning

Skipping configuration 'M_PI_2' since the value of 'M_PI_2' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly.
src/display.c
const double radius = 8.0;
cairo_new_sub_path(cr);
cairo_arc(cr, x + width - radius, y + radius, radius, -DISPLAY_M_PI_2, 0);
cairo_arc(cr, x + width - radius, y + height - radius, radius, 0, DISPLAY_M_PI_2);

Check warning

Code scanning / Cppcheck (reported by Codacy)

Skipping configuration 'M_PI_2' since the value of 'M_PI_2' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. Warning

Skipping configuration 'M_PI_2' since the value of 'M_PI_2' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly.
src/display.c
cairo_new_sub_path(cr);
cairo_arc(cr, x + width - radius, y + radius, radius, -DISPLAY_M_PI_2, 0);
cairo_arc(cr, x + width - radius, y + height - radius, radius, 0, DISPLAY_M_PI_2);
cairo_arc(cr, x + radius, y + height - radius, radius, DISPLAY_M_PI_2, DISPLAY_M_PI);

Check warning

Code scanning / Cppcheck (reported by Codacy)

Skipping configuration 'M_PI' since the value of 'M_PI' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. Warning

Skipping configuration 'M_PI' since the value of 'M_PI' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly.
src/display.c
cairo_new_sub_path(cr);
cairo_arc(cr, x + width - radius, y + radius, radius, -DISPLAY_M_PI_2, 0);
cairo_arc(cr, x + width - radius, y + height - radius, radius, 0, DISPLAY_M_PI_2);
cairo_arc(cr, x + radius, y + height - radius, radius, DISPLAY_M_PI_2, DISPLAY_M_PI);

Check warning

Code scanning / Cppcheck (reported by Codacy)

Skipping configuration 'M_PI_2' since the value of 'M_PI_2' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. Warning

Skipping configuration 'M_PI_2' since the value of 'M_PI_2' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly.
src/display.c
cairo_arc(cr, x + width - radius, y + radius, radius, -DISPLAY_M_PI_2, 0);
cairo_arc(cr, x + width - radius, y + height - radius, radius, 0, DISPLAY_M_PI_2);
cairo_arc(cr, x + radius, y + height - radius, radius, DISPLAY_M_PI_2, DISPLAY_M_PI);
cairo_arc(cr, x + radius, y + radius, radius, DISPLAY_M_PI, 1.5 * DISPLAY_M_PI);

Check warning

Code scanning / Cppcheck (reported by Codacy)

Skipping configuration 'M_PI' since the value of 'M_PI' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. Warning

Skipping configuration 'M_PI' since the value of 'M_PI' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly.
@damachine damachine closed this Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@damachine