Open
Conversation
\#\# Rewrote as a class, so the sensor can be instatiated like an object. * See the test script for an example. * notable advantages to this approach is that you can have several of the same type of sensor and not confuse them. You can also standardize your interface with sensors if you start using more of them. * Commands are now stored as a Dictionary, which you can add to. * HTU attributes are: address, commands, bus. \#\# Fixed some math bugs * Most notably, humidity needed to be bit shifted by 2 (divided by 4) because it is only a 12-bit reading. You probably found your humidity readings are in the 130% range. This is the cause. * Added the float() expression and removed the need for importing math module. It's a builtin and also won't make an absolute value like math.fabs() * rounded returns to 2 decimal places. I can't thank you enough for your original driver, but hopefully you're still curating this repo! -Phantom410
brunoac6
approved these changes
Sep 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrote as a class, so the sensor can be instatiated like an object.
Fixed some math bugs
I can't thank you enough for your original driver, but hopefully you're still curating this repo!
-Phantom410