Skip to content

Comments

添加了动画过渡效果#47

Open
zhangruize wants to merge 1 commit intodaimajia:masterfrom
zhangruize:master
Open

添加了动画过渡效果#47
zhangruize wants to merge 1 commit intodaimajia:masterfrom
zhangruize:master

Conversation

@zhangruize
Copy link

Add animation between every setProgress.

Add animation between every setProgress.
@daimajia
Copy link
Owner

daimajia commented Oct 3, 2017

Hi @zhangruize ,
It's really a marvelous feature for this tiny library!

There are some suggestions on the code part, hope you can do some update.

  • add a comment on the ANIMATION_DURATION varaible, and it's better to allow developers to modify the animation_duration
  • allow developers to customize the Interpolator
  • allow developers to enable or disable this feature.

Really thanks for your contribution on this project. 🌹 Looking forward to your update on this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants