feat(api): add feed sentiment backend support#3596
Open
Daily-Dave wants to merge 3 commits intomainfrom
Open
Conversation
Implement backend infrastructure for capturing and storing user feed sentiment feedback. **Features:** - FeedSentiment entity with TypeORM - GraphQL mutation submitFeedSentiment with rate limiting - Database migration for feed_sentiment table - Foreign key constraint to user table with CASCADE delete - Indexes on userId, sentiment, and createdAt for efficient querying **Technical Details:** - Rate limited to 5 submissions per hour per user - Validates sentiment values (good, neutral, bad) - Registered in GraphQL schema with typeDefs and resolvers - Migration: 1771326220000-AddFeedSentimentTable.ts Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
**Critical Fixes:** - Fix User import path from './user' to './user/User' (CLAUDE.md compliance) - Use ValidationError instead of Error for GraphQL validation - Remove unnecessary comments per CLAUDE.md guidelines **Changes:** - FeedSentiment.ts: Corrected import path to avoid barrel file - feedSentiment.ts: Added ValidationError import from apollo-server-errors - feedSentiment.ts: Use ValidationError for invalid sentiment values - Removed redundant comments that restate code Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
|
|
🍹 The Update (preview) for dailydotdev/api/prod (at 1f88c9b) was successful. ✨ Neo ExplanationThis deployment rolls out a new API version across all services while simultaneously decommissioning the `worker-job` worker (and its Pub/Sub queue infrastructure), removing three config variables, and updating node scheduling preferences to favor spot instances. The main risk is potential loss of any messages queued in the `worker-job-execute` subscription at the time of deletion.Root Cause AnalysisTwo concurrent changes are being deployed: (1) a new application version rollout (new container image for all API services), and (2) an infrastructure refactor that removes the Dependency Chain
Risk analysisThe Resource Changes |
capJavert
reviewed
Feb 17, 2026
| unknown, | ||
| BaseContext | ||
| >({ | ||
| Mutation: { |
Contributor
There was a problem hiding this comment.
this could be in existing feed schema
Contributor
There was a problem hiding this comment.
It should just be frontend mock for now I think.
Contributor
There was a problem hiding this comment.
yeah but still, no need to create whole new gql schema for this?
| export * from './campaign'; | ||
| export * from './PersonalAccessToken'; | ||
| export * from './Feedback'; | ||
| export * from './FeedSentiment'; |
Contributor
There was a problem hiding this comment.
we don't use barrel files, so this needs to be removed, its in AGENTS.md but agent ignored it...
Comment on lines
+29
to
+32
| const validSentiments = ['good', 'neutral', 'bad']; | ||
| if (!validSentiments.includes(sentiment)) { | ||
| throw new ValidationError('Invalid sentiment value'); | ||
| } |
Contributor
There was a problem hiding this comment.
this should be validated with zod
capJavert
reviewed
Feb 17, 2026
Comment on lines
+33
to
+37
| const feedSentimentRepo = ctx.con.getRepository(FeedSentiment); | ||
| await feedSentimentRepo.save({ | ||
| userId: ctx.userId, | ||
| sentiment, | ||
| }); |
Contributor
There was a problem hiding this comment.
So user can add single sentiment? since user can have multiple feeds maybe better to also add feedId, but not blocking more of a expansion opportunity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements backend infrastructure for capturing and storing user feed sentiment feedback to support the frontend sentiment popup feature.
Changes
submitFeedSentimentmutation with rate limiting (5 submissions/hour)feed_sentimenttable with indexes on userId, sentiment, and createdAtKey Decisions
Closes ENG-720
Created by Huginn 🐦⬛