Skip to content

Fix memory leak, unsafe non-null assertion, and stale useMemo deps #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daihua2 merged 2 commits into from
Mar 27, 2026
Merged

Fix memory leak, unsafe non-null assertion, and stale useMemo deps #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fae172e
Initial plan
Copilot Mar 27, 2026
53b4a97
Fix memory leak, unsafe non-null assertion, and stale useMemo depende…
Copilot Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/material-react-table/src/components/head/MRT_TableHeadCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ export const MRT_TableHeadCell = <TData extends MRT_RowData>({
column={column}
table={table}
tableHeadCellRef={{
current: tableHeadCellRefs.current?.[column.id]!,
current: tableHeadCellRefs.current?.[column.id] ?? null,
}}
/>
)}
Expand Down
10 changes: 5 additions & 5 deletions packages/material-react-table/src/hooks/useMRT_Effects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,10 @@ export const useMRT_Effects = <TData extends MRT_RowData>(

//fix pinned row top style when density changes
useEffect(() => {
if (enableRowPinning && getIsSomeRowsPinned()) {
setTimeout(() => {
rerender();
}, 150);
}
if (!enableRowPinning || !getIsSomeRowsPinned()) return undefined;
const timeoutId = setTimeout(() => {
rerender();
}, 150);
return () => clearTimeout(timeoutId);
}, [density]);
};
6 changes: 3 additions & 3 deletions packages/material-react-table/src/hooks/useMRT_TableOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,10 @@ export const useMRT_TableOptions: <TData extends MRT_RowData>(
mrtTheme = useMemo(() => getMRTTheme(mrtTheme, theme), [mrtTheme, theme]);
aggregationFns = useMemo(
() => ({ ...MRT_AggregationFns, ...aggregationFns }),
[],
[aggregationFns],
);
filterFns = useMemo(() => ({ ...MRT_FilterFns, ...filterFns }), []);
sortingFns = useMemo(() => ({ ...MRT_SortingFns, ...sortingFns }), []);
filterFns = useMemo(() => ({ ...MRT_FilterFns, ...filterFns }), [filterFns]);
sortingFns = useMemo(() => ({ ...MRT_SortingFns, ...sortingFns }), [sortingFns]);
defaultColumn = useMemo(
() => ({ ...MRT_DefaultColumn, ...defaultColumn }),
[defaultColumn],
Expand Down
Loading