Feat add support for KORG logue units#232
Open
dagargo wants to merge 21 commits into
Open
Conversation
dagargo
force-pushed
the
feat-add-korg-logue
branch
from
dce49d3 to
0e7a0cb
Compare
This is a reimplementation of the `logue-cli` tool from KORG.
Response data requieres a fix to be similar to the request data. There is an additional byte at position 9 and requieres the following bytes to be shifted backwards.
In the MIDI implementation charts, responses are not the same for NTS-1 and Minilogue XD.
The channel is required for the devices to reply.
Improve user module info operation code too.
This allows the same filesystem to perform different operations at save depending on the actual device and eliminates the need of having different save functions when several devices are implemented in the same filesystem.
dagargo
force-pushed
the
feat-add-korg-logue
branch
from
0e7a0cb to
6f0b80b
Compare
This fixes occasional errors due to non NULL characters beyond the end of the string.
This fixes occasional errors due to uninitialized versions values.
Owner
Author
|
Apparently, the errors are caused by the checksum in the test zip files not being the same even though the files inside them are exactly equal. It looks like it might be caused by differences in the libzip versions in Debian and Ubuntu so I'll rewrite the tests to bypass this and check only the extracted file content. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The supported devices are the prologue, minilogue xd and NTS-1.