Skip to content

feat: Add exceptions for illegal arguments #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JannisHaeffner merged 1 commit into from
Jan 29, 2026
Merged

feat: Add exceptions for illegal arguments #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions src/main/java/LIC.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@

public class LIC {

public static boolean LIC0(int numPoints, Point[] points, Parameters p) {
if (p.LENGTH1 < 0) return false;
public static boolean LIC0(int numPoints, Point[] points, Parameters p) throws IllegalArgumentException {
if (p.LENGTH1 < 0 || numPoints < 2) {
throw new IllegalArgumentException();
}
for (int i = 0; i < numPoints - 1; i++) {
if (Point.distance(points[i], points[i + 1]) > p.LENGTH1)
return true;
Expand Down Expand Up @@ -85,9 +87,11 @@ public static boolean LIC5(int numPoints, Point[] points, Parameters p) {
return false;
}

public static boolean LIC6(int numPoints, Point[] points, Parameters p) {
if (numPoints < 3 || p.N_PTS < 3 || p.DIST < 0 || numPoints < p.N_PTS ||
p.DIST < 0) return false;
public static boolean LIC6(int numPoints, Point[] points, Parameters p) throws IllegalArgumentException {
if (numPoints < 3) return false;
if (p.N_PTS < 3 || p.DIST < 0 || numPoints < p.N_PTS) {
throw new IllegalArgumentException();
}

for (int i = 0; i <= numPoints - p.N_PTS; i++) {
Point p_start = points[i];
Expand Down Expand Up @@ -152,9 +156,11 @@ public static boolean LIC9(int numPoints, Point[] points, Parameters p){
return false;
}

public static boolean LIC10(int numPoints, Point[] points, Parameters p) {
if (numPoints < 5 || p.E_PTS < 1 ||p.F_PTS < 1 || p.E_PTS + p.F_PTS > numPoints - 3 ||
p.AREA1 < 0) return false;
public static boolean LIC10(int numPoints, Point[] points, Parameters p) throws IllegalArgumentException {
if (numPoints < 5) return false;
if (p.E_PTS < 1 ||p.F_PTS < 1 || p.E_PTS + p.F_PTS > numPoints - 3 || p.AREA1 < 0) {
throw new IllegalArgumentException();
}

for (int i = 0; i < numPoints - p.F_PTS - p.E_PTS - 2; i ++) {
Point p1 = points[i];
Expand Down
19 changes: 19 additions & 0 deletions src/test/java/DecideTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,25 @@ public void CMV_is_Vector_15_And_Only_True_Or_False() {

int numPoints = points.length;
Parameters p = new Parameters();
p.LENGTH1 = 0; //Best for all LICS
p.RADIUS1 = 0; //Best for all LICS
p.EPSILON = 0; //Best for all LICS
p.AREA1 = 0; //Best for all LICs
p.Q_PTS = 5; // The one in LIC4 testcase
p.QUADS = 2; // Same for LIC4
p.DIST = 3.0; //Same for LIC6
p.N_PTS = 3; //Same for LIC6
p.K_PTS = 1; //same for LIC7 and LIC12
p.A_PTS = 1; //Same for LIC8 and LIC 13
p.B_PTS = 1; //Same for LIC8 and LIC 13
p.C_PTS = 1; //Same for LIC9
p.D_PTS = 1; //Same for LIC9
p.E_PTS = 1; //Same for LIC 10 and 14
p.F_PTS = 1; //Same for LIC 10 and 14
p.G_PTS = 1; //Same for LIC 11
p.LENGTH2 = 10000;
p.RADIUS2 = 10000;
p.AREA2 = 10000;
Matrix cmv = Decide.CMV(numPoints, points, p);

assertEquals(15, cmv.M);
Expand Down
127 changes: 89 additions & 38 deletions src/test/java/LICTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,21 +146,21 @@ void LIC0_false_with_smaller_distance() {
}

@Test
// Contract: LIC0 is false iff less than two points exist.
void LIC0_false_with_too_few_points() {
// Contract: LIC0 throws an IllegelArgumentException if less than two points exist.
void LIC0_throws_with_too_few_points() {
Parameters p = new Parameters();
p.LENGTH1 = 4;
Point[] pts = { new Point(0, 0) };
assertFalse(LIC.LIC0(pts.length, pts, p));
assertThrows(IllegalArgumentException.class, () -> LIC.LIC0(pts.length, pts, p));
}

@Test
// Contract: LIC0 is false iff LENGTH1 < 0
void LIC0_false_with_length_too_small() {
// Contract: LIC0 throws an IllegelArgumentException if LENGTH1 < 0
void LIC0_throws_with_length_too_small() {
Parameters p = new Parameters();
p.LENGTH1 = -1;
Point[] pts = { new Point(0, 0), new Point(3, 4)};
assertFalse(LIC.LIC0(pts.length, pts, p));
assertThrows(IllegalArgumentException.class, () -> LIC.LIC0(pts.length, pts, p));
}

@Test
Expand Down Expand Up @@ -494,8 +494,8 @@ public void LIC6_false_with_too_few_points() {
}

@Test
public void LIC6_false_with_DIST_too_small() {
// Contract: LIC6 is false iff DIST < 0
public void LIC6_throws_exception_with_DIST_too_small() {
// Contract: LIC6 throws an exception iff DIST < 0
Parameters p = new Parameters();
p.N_PTS = 3;
p.DIST = -1;
Expand All @@ -511,12 +511,12 @@ public void LIC6_false_with_DIST_too_small() {
new Point(6, 0),
new Point(1, -1)
};
assertFalse(LIC.LIC6(points3.length, points3, p));
assertThrows(IllegalArgumentException.class, () -> LIC.LIC6(points3.length, points3, p));
}

@Test
public void LIC6_false_with_too_small_N_PTS() {
// Contract: LIC6 is false iff N_PTS < 3
public void LIC6_throws_exception_with_too_small_N_PTS() {
// Contract: LIC6 throws an exception iff N_PTS < 3
Parameters p = new Parameters();
p.N_PTS = 2;
p.DIST = 30;
Expand All @@ -532,7 +532,28 @@ public void LIC6_false_with_too_small_N_PTS() {
new Point(6, 0),
new Point(1, -1)
};
assertFalse(LIC.LIC6(points2.length, points2, p));
assertThrows(IllegalArgumentException.class, () -> LIC.LIC6(points2.length, points2, p));
}

@Test
public void LIC6_throws_exception_with_N_PTS_bigger_than_numpoints() {
// Contract: LIC6 throws an exception iff N_PTS > numpoints
Parameters p = new Parameters();
p.N_PTS = 20;
p.DIST = 30;
Point[] points2 = new Point[] {
new Point(0, 0),
new Point(1, 0),
new Point(2, 0),
new Point(1, 1),
new Point(2, 2),
new Point(1, 1),
new Point(0, 3),
new Point(1, 2),
new Point(6, 0),
new Point(1, -1)
};
assertThrows(IllegalArgumentException.class, () -> LIC.LIC6(points2.length, points2, p));
}

@Test
Expand Down Expand Up @@ -843,57 +864,87 @@ public void LIC10_false_when_too_few_points() {
}

@Test
public void LIC10_false_when_area_too_small() {
// Contract: LIC10 is false if the area is smaller than 0
public void LIC10_throws_exception_when_area_too_small() {
// Contract: LIC10 throws exception if the area is smaller than 0
Point [] points = new Point[] {
new Point(1, 0),
new Point(0, 0),
new Point(1, 0)
new Point(1, 0),
new Point(1, 0),
new Point(0, 0),
new Point(0, 0),
new Point(1, 0),
new Point(1, 0),
new Point(0, 0)
};
Parameters p = new Parameters();
p.E_PTS = 2;
p.F_PTS = 2;
p.AREA1 = -1;
assertFalse(LIC.LIC10(3, points, p));
assertThrows(IllegalArgumentException.class, () -> LIC.LIC10(points.length, points, p));
}

@Test
public void LIC10_false_when_EPTS_plus_FTPS_too_large() {
// Contract: LIC10 is false if E_PTS + F_PTS <= numpoints - 3
@Test
public void LIC10_throws_exception_when_EPTS_too_small() {
// Contract: LIC10 throws exception if the EPTS < 1
Point [] points = new Point[] {
new Point(1, 0),
new Point(0, 0),
new Point(1, 0),
new Point(1, 0),
new Point(0, 0),
new Point(1, 0)
new Point(0, 0),
new Point(1, 0),
new Point(1, 0),
new Point(0, 0)
};
Parameters p = new Parameters();
p.E_PTS = 1;
p.E_PTS = 0;
p.F_PTS = 2;
p.AREA1 = 10;
assertFalse(LIC.LIC10(5, points, p));
p.AREA1 = 4;
assertThrows(IllegalArgumentException.class, () -> LIC.LIC10(points.length, points, p));
}

@Test
public void LIC10_false_with_smaller_area() {
/*
* Contract: LIC10 is false iff there exists no set of three data points
* separated by exactly E PTS and F PTS consecutive intervening points, respectively,
* that are the vertices of a triangle with area greater than AREA1.
*/
public void LIC10_throws_exception_when_FPTS_too_small() {
// Contract: LIC10 throws exception if FPTS < 1
Point [] points = new Point[] {
new Point(1, 0),
new Point(0, 1),
new Point(2, 0),
new Point(0, 2),
new Point(1, 1),
new Point(1, 1)
new Point(0, 0),
new Point(1, 0),
new Point(1, 0),
new Point(0, 0),
new Point(0, 0),
new Point(1, 0),
new Point(1, 0),
new Point(0, 0)
};
Parameters p = new Parameters();
p.E_PTS = 1;
p.F_PTS = 1;
p.AREA1 = 10;
assertFalse(LIC.LIC10(points.length, points, p));
p.E_PTS = 2;
p.F_PTS = 0;
p.AREA1 = 4;
assertThrows(IllegalArgumentException.class, () -> LIC.LIC10(points.length, points, p));
}

@Test
public void LIC10_throws_exception_when_EPTS_plus_FPTS_too_large() {
// Contract: LIC10 throws exception if EPTS + FPTS > numpoints - 3
Point [] points = new Point[] {
new Point(1, 0),
new Point(0, 0),
new Point(1, 0),
new Point(1, 0),
new Point(0, 0),
new Point(0, 0),
new Point(1, 0),
new Point(1, 0),
new Point(0, 0)
};
Parameters p = new Parameters();
p.E_PTS = 5;
p.F_PTS = 5;
p.AREA1 = 4;
assertThrows(IllegalArgumentException.class, () -> LIC.LIC10(points.length, points, p));
}

@Test
Expand Down