Skip to content

chore: promote dev to main — gui v0.14.0 (Mantis #1256)#6

Merged
Snider merged 1 commit intomainfrom
dev
Apr 30, 2026
Merged

chore: promote dev to main — gui v0.14.0 (Mantis #1256)#6
Snider merged 1 commit intomainfrom
dev

Conversation

@Snider
Copy link
Copy Markdown
Contributor

@Snider Snider commented Apr 30, 2026 •
edited by coderabbitai Bot
Loading

Brings v0.14.0 to main: wire c.Process() into TIM container + marketplace git runner. Closes Mantis #1256.

Summary by CodeRabbit

  • Refactor
    • Service configuration refactored to automatically manage default command execution callbacks when none are explicitly provided, with improved error propagation
    • Marketplace installation git runner management updated to use service-level methods instead of package-level functions, including enhanced error handling and flexible output processing

@Snider @codex
refactor(go): wire c.Process() into TIM container Exec + marketplace …
5fd5b5c 
…git runner (Mantis #1256)

Migrate two os/exec entry points to use core/go's c.Process() primitive
instead of bypassing it:

- pkg/container/service.go: NewService now wires options.Exec to a
  c.Process().Run(...) shim when not test-overridden, so TIM container
  exec goes through Core's process layer (gets logging, panic recovery,
  context propagation).
- pkg/display/marketplace.go: marketplaceGitRunner() returns a Core-
  backed runner when no test override is set, replacing direct os/exec
  shelling for marketplace git installs.

Audit delta: 3366 → 3367 (+1, false-positive on err-shape-funcs regex
from the closure-return signature `func ... ([]byte, error) {`. The
closure is required by marketplace.Installer's GitRunner field shape;
not real err-shape gaming).

0 cli-batch-helpers, 0 i18n-standalone, 0 local-error-helpers added.
Build, vet, test all clean.

Closes tasks.lthn.sh/view.php?id=1256

Co-authored-by: Codex <noreply@openai.com>
@Snider Snider merged commit e2dd3a6 into main Apr 30, 2026
2 of 4 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c7e9c1df-b369-4fb8-b679-2e3676902345

📥 Commits

Reviewing files that changed from the base of the PR and between 63a9ddb and 5fd5b5c.

📒 Files selected for processing (2)
  • go/pkg/container/service.go
  • go/pkg/display/marketplace.go
📝 Walkthrough

Walkthrough

The pull request integrates command execution through core.Process().Run into two components. The container service now provides a default execution callback when none is supplied and a core reference is available. The marketplace display component shifts to obtain its git runner through a new service method that conditionally uses core process execution.

Changes

Cohort / File(s) Summary
Container Service Execution Callback
go/pkg/container/service.go		 Adds conditional default TIMOptions.Exec callback in NewService that executes commands through c.Process().Run, treating successful results as nil errors and propagating failures appropriately.
Marketplace Git Runner Integration
go/pkg/display/marketplace.go		 Introduces Service.marketplaceGitRunner() method that conditionally returns a git runner implementation using core.Process().Run for command execution, with output normalised to []byte.

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

❌ Patch coverage is 17.85714% with 23 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
go/pkg/display/marketplace.go 20.00% 16 Missing ⚠️
go/pkg/container/service.go 12.50% 6 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 30, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 30, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Snider