Skip to content

fix(go): hotfix defer/import errors from v0.16.0 → v0.17.0 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Snider merged 1 commit into from
Apr 30, 2026
Merged

fix(go): hotfix defer/import errors from v0.16.0 → v0.17.0 #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/collect/bitcointalk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@
if err != nil {
return "", err
}
defer resp.Body.Close
defer resp.Body.Close()

Check failure on line 236 in go/collect/bitcointalk.go

View workflow job for this annotation

GitHub Actions / golangci-lint 

Error return value of `resp.Body.Close` is not checked (errcheck)

Check failure on line 236 in go/collect/bitcointalk.go

View workflow job for this annotation

GitHub Actions / golangci-lint 

Error return value of `resp.Body.Close` is not checked (errcheck)
if resp.StatusCode >= 400 {
return "", core.E("collect.BitcoinTalkCollector", core.Sprintf("http %s", resp.Status), nil)
}
Expand Down
2 changes: 1 addition & 1 deletion go/jobrunner/journal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
if !ok {
return core.E(sonarJournalJobrunnerJournalAppend, "open journal returned invalid writer", nil)
}
defer f.Close
defer f.Close()

Check failure on line 134 in go/jobrunner/journal.go

View workflow job for this annotation

GitHub Actions / golangci-lint 

Error return value of `f.Close` is not checked (errcheck)

Check failure on line 134 in go/jobrunner/journal.go

View workflow job for this annotation

GitHub Actions / golangci-lint 

Error return value of `f.Close` is not checked (errcheck)

if _, err := f.Write(append(payload, '\n')); err != nil {
return core.E(sonarJournalJobrunnerJournalAppend, "write journal", err)
Expand Down
2 changes: 0 additions & 2 deletions go/plugin/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// SPDX-License-Identifier: EUPL-1.2

package plugin

import "testing"
Loading