Conversation
Migrate go-scm error construction and command-registration patterns to
canonical core/go primitives:
- go/scm.go: drop `errors` import; use `core.E(op, msg, cause)`
instead of `errors.New(...)` in NewCoreService nil-check
- go/git/service.go: similar core.E migrations
- go/cmd/{collect,compile,forge,gitea,pkg,scm,sign,verify}/...: bulk
conversion of `_ = app.Command(...)` discards to inline propagation
`if r := app.Command(...); !r.OK { return r }`. Several `newApp()`
helpers changed signature from `func newApp() *core.Core` to
`func newApp() core.Result` so registration failures propagate to
main(), which then handles them via `core.Exit(1)` after logging.
10 files changed, 386/-249. Audit: 3180 → 3154 (-26 result-discards).
Build, vet, test all clean. 0 gaming patterns across all dims.
Closes tasks.lthn.sh/view.php?id=1248
Co-authored-by: Codex <noreply@openai.com>
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings v0.15.0 to main: refactor(go) using core.E + Result propagation. Audit: 3180 → 3154 (-26). Closes Mantis #1248.