Conversation
…216)
Convert bare `c.Command(...)` discard calls in agent's command
registration helpers to inline propagation:
if r := c.Command("path", core.Command{...}); !r.OK { return r }
Each `registerXCommands(...)` function now returns core.Result and
threads errors back to the caller. The lane originally introduced a
commandRegistration struct + registerCommandSet/registerMissingCommandSet
helpers as an abstraction layer; those were inlined back to direct
c.Command(...) calls per Snider's review ("use core/go primitives,
don't build framework on top of them"). Net effect: same Result-
propagation behaviour without the new API surface.
Files:
go/cmd/core-agent/{commands,main}.go
go/pkg/agentic/commands{,_commit,_core,_forge,_phase,_plan,_platform,
_session,_setup,_sprint,_state,_task,_workspace}.go
go/pkg/agentic/{fleet_mode,lang,pipeline_commands,prep,
process_register,repo_sync}.go
go/pkg/lib/lib.go
22 files changed. Audit (audit.sh) baseline 2527 → 2513 (-14
result-discards, no new findings). Build, vet, test all clean. 0
gaming patterns.
Closes tasks.lthn.sh/view.php?id=1216
Co-authored-by: Codex <noreply@openai.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
❌ The last analysis has failed. |
|
❌ The last analysis has failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings v0.27.0 to main: refactor(go) propagating command-registration Result inline. Audit: 2527 → 2513 (-14). Closes Mantis #1216.