MSIM compilation on 32bit systems#94
Draft
rosenbergm wants to merge 4 commits intomasterfrom
Draft
Conversation
rosenbergm
force-pushed
the
issue/91-compile-on-32bit-systems
branch
from
ca2a513 to
0bd2f78
Compare
This is done by looking at the size of a pointer on the host system. This tells us whether the system is 32 or 64 bit. We then expose a variable to act accordingly.
rosenbergm
force-pushed
the
issue/91-compile-on-32bit-systems
branch
from
0bd2f78 to
2598ea1
Compare
Collaborator
Author
|
One more thing (and the reason this PR is still a draft) is that I am not sure if test will compile now on 32 bit systems. I think we need to exclude the 64bit tests when running tests on a 32bit machine. Could you @vhotspur please test if tests are running on 32bit platforms? I can't get it to compile in a 32bit environment. Also we could add a 32 bit system as a runner for tests... if that is even possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#91