Skip to content

fix: Restore correct snapshot for parse-news-items external contributor test#1042

Draft
Copilot wants to merge 2 commits intosnapshot-main-R-CMD-check-base-nullfrom
copilot/sub-pr-1036
Draft

fix: Restore correct snapshot for parse-news-items external contributor test#1042
Copilot wants to merge 2 commits intosnapshot-main-R-CMD-check-base-nullfrom
copilot/sub-pr-1036

Conversation

Copy link
Copy Markdown

Copilot AI commented Feb 26, 2026

The automated snapshot-update CI action incorrectly accepted an httptest2 mock error as expected output for the "Can parse PR merge commits - external contributor" test. The fixture file tests/fixtures/pr0/api.github.com/repos/cynkra/fledge/pulls/18.json exists and the test passes correctly — the CI environment simply failed to resolve the mock at that moment.

Changes

  • tests/testthat/_snaps/parse-news-items.md
    • Reverts the "external contributor" snapshot from the captured httptest2 error back to the correct expected output: "Improve parsing of conventional commit messages (@someon~" with type Features
    • Restores the "Can parse PR merge commits - PAT absence" snapshot section, which was dropped when snapshot_accept() ran in an offline environment (skipped test left no new snapshot output, causing the section to be omitted from the regenerated file)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…or test

Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented Feb 26, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • captive.apple.com
    • Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R /opt/R/4.5.2/lib/R/bin/exec/R -e ~n~devtools::load_all(&#39;.&#39;)~n~#~&#43;~Run~&#43;~just~&#43;~the~&#43;~parse-news-items~&#43;~tests~n~testthat::test_file(&#39;tests/testthat/test-parse-news-items.R&#39;,~&#43;~reporter~&#43;~=~&#43;~&#39;progress&#39;,~&#43;~stop_on_failure~&#43;~=~&#43;~FALSE)~n~ (dns block)
    • Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R /opt/R/4.5.2/lib/R/bin/exec/R -e ~n~devtools::load_all(&#39;.&#39;)~n~testthat::test_file(&#39;tests/testthat/test-parse-news-items.R&#39;,~&#43;~reporter~&#43;~=~&#43;~&#39;progress&#39;,~&#43;~stop_on_failure~&#43;~=~&#43;~FALSE)~n~ (dns block)
    • Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R /opt/R/4.5.2/lib/R/bin/exec/R -e ~n~devtools::load_all(&#39;.&#39;)~n~testthat::test_file(&#39;tests/testthat/test-parse-news-items.R&#39;,~&#43;~reporter~&#43;~=~&#43;~&#39;location&#39;,~&#43;~stop_on_failure~&#43;~=~&#43;~FALSE)~n~ (dns block)
  • dns.google.com
    • Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R /opt/R/4.5.2/lib/R/bin/exec/R -e ~n~devtools::load_all(&#39;.&#39;)~n~#~&#43;~Run~&#43;~just~&#43;~the~&#43;~parse-news-items~&#43;~tests~n~testthat::test_file(&#39;tests/testthat/test-parse-news-items.R&#39;,~&#43;~reporter~&#43;~=~&#43;~&#39;progress&#39;,~&#43;~stop_on_failure~&#43;~=~&#43;~FALSE)~n~ (dns block)
    • Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R /opt/R/4.5.2/lib/R/bin/exec/R -e ~n~devtools::load_all(&#39;.&#39;)~n~testthat::test_file(&#39;tests/testthat/test-parse-news-items.R&#39;,~&#43;~reporter~&#43;~=~&#43;~&#39;progress&#39;,~&#43;~stop_on_failure~&#43;~=~&#43;~FALSE)~n~ (dns block)
    • Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R /opt/R/4.5.2/lib/R/bin/exec/R -e ~n~devtools::load_all(&#39;.&#39;)~n~testthat::test_file(&#39;tests/testthat/test-parse-news-items.R&#39;,~&#43;~reporter~&#43;~=~&#43;~&#39;location&#39;,~&#43;~stop_on_failure~&#43;~=~&#43;~FALSE)~n~ (dns block)
  • https://api.github.com/repos/cynkra/fledge/pulls/18
    • Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R /opt/R/4.5.2/lib/R/bin/exec/R -e ~n~#~&#43;~Try~&#43;~to~&#43;~figure~&#43;~out~&#43;~the~&#43;~actual~&#43;~request~&#43;~URL~&#43;~by~&#43;~intercepting~&#43;~it~n~library(gh)~n~library(httptest2)~n~~n~#~&#43;~Set~&#43;~up~&#43;~environment~&#43;~for~&#43;~the~&#43;~test~n~Sys.setenv(&#39;FLEDGE_YES_INTERNET_TEST&#39;~&#43;~=~&#43;~&#39;yes&#39;)~n~Sys.setenv(&#39;GITHUB_PAT&#39;~&#43;~= owner --uid-owner sh)))~n~ -j ACCEPT (http block)
  • time.cloudflare.com
    • Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R /opt/R/4.5.2/lib/R/bin/exec/R -e ~n~devtools::load_all(&#39;.&#39;)~n~#~&#43;~Run~&#43;~just~&#43;~the~&#43;~parse-news-items~&#43;~tests~n~testthat::test_file(&#39;tests/testthat/test-parse-news-items.R&#39;,~&#43;~reporter~&#43;~=~&#43;~&#39;progress&#39;,~&#43;~stop_on_failure~&#43;~=~&#43;~FALSE)~n~ (dns block)
    • Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R /opt/R/4.5.2/lib/R/bin/exec/R -e ~n~devtools::load_all(&#39;.&#39;)~n~testthat::test_file(&#39;tests/testthat/test-parse-news-items.R&#39;,~&#43;~reporter~&#43;~=~&#43;~&#39;progress&#39;,~&#43;~stop_on_failure~&#43;~=~&#43;~FALSE)~n~ (dns block)
    • Triggering command: /opt/R/4.5.2/lib/R/bin/exec/R /opt/R/4.5.2/lib/R/bin/exec/R -e ~n~devtools::load_all(&#39;.&#39;)~n~testthat::test_file(&#39;tests/testthat/test-parse-news-items.R&#39;,~&#43;~reporter~&#43;~=~&#43;~&#39;location&#39;,~&#43;~stop_on_failure~&#43;~=~&#43;~FALSE)~n~ (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update snapshot for R-CMD-check-base fix: Restore correct snapshot for parse-news-items external contributor test Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants