fix: prevent incorrect scheme addition in URL parsing#1
Open
rjvkn wants to merge 1 commit intocyinnove:mainfrom
Open
fix: prevent incorrect scheme addition in URL parsing#1rjvkn wants to merge 1 commit intocyinnove:mainfrom
rjvkn wants to merge 1 commit intocyinnove:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an issue in the
tldify.Parsefunction where URLs with either thehttp://orhttps://scheme were incorrectly being parsed with an additional scheme. The problem occurred because the function was always prependinghttp://, even when the URL already had one of these schemes.Changes
Parsewas modified to check whether the URL already starts withhttp://orhttps://before prepending any scheme.Motivation and Context
This change prevents incorrect scheme duplication and ensures that URLs like
https://example.comare handled correctly.How to Test
You can test this fix by passing URLs like
https://example.comand checking that the function does not prependhttp://again. Any URLs without a scheme should receivehttp://as expected.Screenshots (if applicable)
Checklist