Skip to content

Feature/#30 allow only logged in users to read user data #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reinierl wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Feature/#30 allow only logged in users to read user data #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99ab3ec
make emulators work with Firebase project set to actual CyclePlanet
reinierl Nov 7, 2021
f870e97
don't allow non logged in people to read user data
reinierl Nov 7, 2021
3bac276
remove useless line from Layout
reinierl Nov 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions database.rules.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,25 +26,13 @@
}
},

// I believe we have to allow everyone to read user profiles atm.
// This is problematic though, as it will disclose details people
// don't necessarily want disclosed, like their exact geo location
// or their full hosting history (which, if I have to press it for
// examples why you may want to hide it, may include celebrities).
//
// This permissive read rule also overrules the restrictive one on
// hosting requests above for now.
//
// Ideally, I (Reinier) believe we'll have separate nodes /Users
// (all information the platform has about a user) and /Profiles
// (all information other people are allowed to see about this user).
// And then platform users could manage to some extent how much of
// what's in their /Users appears in their /Profile too or not.
".read": true,
// only logged in users can read user data
// this should actually be restricted further: https://github.com/cycleplanet/cycle-planet/issues/31
".read": "auth !== null" ,
".write": "auth.uid === $userId",
".validate": true
},
".read": true,
".read": "auth !== null",
".write": false,
".validate": true
},
Expand Down
0 ...cycleplanet-dev-reinier-default-rtdb.json → ...a/database_export/cycle-planet-292f5.json
View file
Open in desktop
File renamed without changes.
3 changes: 1 addition & 2 deletions src/layouts/Layout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<q-space></q-space>

<q-tabs v-model="tab" shrink v-if="screenwidthbig">
<q-btn flat name="Map" label="Map" to="/map" />
<q-btn flat name="Map" label="Map" to="/map" v-if="loggedIn" />
<q-btn
v-if="teamMember"
flat
Expand Down Expand Up @@ -225,7 +225,6 @@
import { mapState, mapActions, mapGetters } from "vuex";
import mixinGeneral from "src/mixins/mixin-general.js";
import mixinHosting from "src/mixins/mixin-hosting.js";
import { LocalStorage, SessionStorage } from 'quasar';

export default {
mixins: [mixinGeneral, mixinHosting],
Expand Down
1 change: 1 addition & 0 deletions src/pages/Other/PageWelcome.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
icon="home"
:label="isWebApp ? 'home' : ''"
class="q-ma-xs justify-end"
v-if="loggedIn"
/>
<q-btn
flat
Expand Down