This repository was archived by the owner on Apr 28, 2026. It is now read-only.
Rsync all system images#205
Closed
scholzp wants to merge 3 commits into
Closed
Conversation
phip1611
approved these changes
Apr 20, 2026
Member
phip1611
left a comment
phip1611
left a comment
There was a problem hiding this comment.
LGTM! Please add information to the commit message about the expected overhead
phip1611
reviewed
Apr 20, 2026
We use `reset_system_image` nowhere, thus we remove it completely. Note: We'll add a similar function in a follow up commit, but decided to remove the function in this commit to reach a consistent state. Signed-off-by: Pascal Scholz <pascal.scholz@cyberus-technology.de> On-behalf-of: SAP pascal.scholz@sap.com
scholzp
force-pushed
the
rsync_all_system_images
branch
from
4d5346d to
2c4c47b
Compare
We perform the same operations for all system images. We therefore introduce a list of image names and create a helper that processes this list instead of repeating code for all images. Signed-off-by: Pascal Scholz <pascal.scholz@cyberus-technology.de> On-behalf-of: SAP pascal.scholz@sap.com
Apply the same workaround for all system images that we already apply for `nixos` to make each test start with a fresh image in a known good state. Signed-off-by: Pascal Scholz <pascal.scholz@cyberus-technology.de> On-behalf-of: SAP pascal.scholz@sap.com
scholzp
force-pushed
the
rsync_all_system_images
branch
from
2c4c47b to
00dab25
Compare
hertrste
previously approved these changes
Apr 27, 2026
Collaborator
hertrste
left a comment
hertrste
left a comment
There was a problem hiding this comment.
I'll approve but if you notice this introduces an unexpected high amount of overhead, we should take a look again :)
Member
|
Should we declare a code freeze here? Because of the transition to the libvirt repo |
hertrste
dismissed
their stale review
I think we should go with the libvirt-tests -> libvirt move first and re-open this PR in libvirt afterwards. Sorry for the inconvinience!
Collaborator
|
Closing due to moving libvirt-tests into libvirt. Please reopen the pr in libvirt repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used
rsyncto reset the NixOS image in the NFS that controllerVM and computeVM are using for their guests. We did so, because we observed that a sytsem/firmware might write to the image even though it is read only (e.g. efivars).The NixOS is not the only image we use to boot systems from. It is only consequent to
rsyncall other images. This PR implements a small helper und utilizes it torsyncall system images.Pipeline: https://gitlab.cyberus-technology.de/cyberus/cloud/libvirt/-/pipelines/215996
I'll add information about the overhead soon.