This repository was archived by the owner on Apr 28, 2026. It is now read-only.
Add Windows test#201
Merged
Merged
Conversation
scholzp
requested review from
Coffeeri,
amphi,
arctic-alpaca,
hertrste and
phip1611
phip1611
reviewed
Apr 14, 2026
Member
There was a problem hiding this comment.
very nice PR!
Boy, our libvirt-tests suite is really getting compelx 😁
Left a few remarks.
I think it would make sense if you also open a draft PR in libvirt that runs this in CI - and link that pipeline in your PR description so that reviewers can check what the outcome is
hertrste
reviewed
Apr 15, 2026
phip1611
approved these changes
Apr 15, 2026
Member
phip1611
left a comment
phip1611
left a comment
There was a problem hiding this comment.
LGTM, thanks for addressing my remarks. Please address the remarks of the others as wel
amphi
suggested changes
Apr 15, 2026
scholzp
force-pushed
the
windows_test
branch
2 times, most recently
from
7eeab8c to
d6cfed7
Compare
scholzp
force-pushed
the
windows_test
branch
2 times, most recently
from
a5b4ae1 to
e0d3c81
Compare
amphi
reviewed
Apr 17, 2026
Contributor
amphi
left a comment
amphi
left a comment
There was a problem hiding this comment.
Just left one comment, otherwise it looks good!
scholzp
force-pushed
the
windows_test
branch
2 times, most recently
from
1343c84 to
1fb6a02
Compare
We collect all Windows specific setup in a dedicated nix derivation. We do so because we don't want to have Windows specific settings in our linux test, as we wont use them anyway. Along with this decoupling comes the advantage that the Windows image will not be included when calling test targets that don't reference this description. Signed-off-by: Pascal Scholz <pascal.scholz@cyberus-technology.de> On-behalf-of: SAP pascal.scholz@sap.com
Make `initialControllerVMSetup` copy only the system images that we will need in our test. We do so as some images are quite large and need considerably time to be copied to the NFS. Signed-off-by: Pascal Scholz <pascal.scholz@cyberus-technology.de> On-behalf-of: SAP pascal.scholz@sap.com
The NFS is stored on the virtual disk of the ControllerVM. We increase its disk size so it has enough space to also host the Windows image, which is 20 Gib in size. Signed-off-by: Pascal Scholz <pascal.scholz@cyberus-technology.de> On-behalf-of: SAP pascal.scholz@sap.com
We don't want to copy the Windows image in all test suites. Moreover, the Windows tests consume a lot of time because of the initial copy created of the image for each test. We therefore refrain from adding Windows test to other test suites and encapsulate them in their own test suite. Signed-off-by: Pascal Scholz <pascal.scholz@cyberus-technology.de> On-behalf-of: SAP pascal.scholz@sap.com
Similar to other CPU profile tests, these test require special hardware to run on. Because of this, we move them to their own test suite and do not merge them with the existing Windows test suite. Signed-off-by: Pascal Scholz <pascal.scholz@cyberus-technology.de> On-behalf-of: SAP pascal.scholz@sap.com
We build the image on our own. Because we there is no script to automatically generate the image, from which one could obtain infromation about the image, we describe it as best as we can in the documentation. Signed-off-by: Pascal Scholz <pascal.scholz@cyberus-technology.de> On-behalf-of: SAP pascal.scholz@sap.com
Along with documenting the Windows test suite we als link the documentation with of the Windows image used in the test suites. Signed-off-by: Pascal Scholz <pascal.scholz@cyberus-technology.de> On-behalf-of: SAP pascal.scholz@sap.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
We need some regression test to not accidentally break Windows support. This commit series prepares for and implement the first Windows tests. These are tests that check that Windows Server 2025 can be booted as a CHV guest with and without CPU profiles.
Pipeline: https://gitlab.cyberus-technology.de/cyberus/cloud/libvirt/-/pipelines/212759