Fix ACPI S5 sleep state package reporting

[tpressure]

OpenBSD expects the ACPI S5 object to provide both sleep type values. The single-value package made acpi_init_states() parse an invalid object and fault during early ACPI setup with:

    acpi0: sleep statesfatal protection fault in supervisor mode
    trap type 4 code 0 rip ffffffff814af264 cs 8 rflags 10282 cr2 0 cpl e rsp ffffffff81a06a30
    gsbase 0xffffffff81755ff0  kgsbase 0x0
    panic: trap type 4, code=0, pc=ffffffff814af264
    Starting stack trace...
    panic(ffffffff81a06980,4,ffffffff81a06a58,ffffffff81756ae0,ffffffff81a06960,ffffffff81a068e0) at panic+0x12e
    kerntrap(ffffffff81a06aa0,ffff800000232400,ffffffff81261681,ffffffff81a06970,ffffffff81a06980,4) at kerntrap+0xe1
    alltraps_kern_meltdown(4,ef0d316e102be1f4,ffff800000232480,0,ffffffff81a06aa0,ffff800000232400) at alltraps_kern_meltdown+0x7b
    aml_val2int(ef0d316e102be1f4,0,10,ffffffff81a06a30,10282,8) at aml_val2int+0x24
    acpi_init_states(1,ffff800000232400,ffff800000232470,0,ef0d316e102be1f4,5f35535f) at acpi_init_states+0xd5
    acpi_attach_common(ffff800000235300,ffffffff81a06cf0,ffffffff81762a00,ffff800000232400,ffff800000232424,ef0d316e102be1f4) at acpi_attach_common+0x311
    config_attach(ffffffff81a06d30,ffff800000235300,50,118,ffff80003158c004,ffffffff813e3270) at config_attach+0x1d2
    bios_attach(ffff800000235280,ffffffff81a06e28,ffffffff8175ca50,ffff800000235300,ffff800000235324,ef0d316e102be1f4) at bios_attach+0x898
    config_attach(ffffffff81a06e28,ffff800000235280,ffffffff81757e68,ffff800000235280,ffff8000002352a4,ffffffff8128c510) at config_attach+0x1d2
    mainbus_attach(0,0,ef0d316e102be1f4,ffffffff81a06e50,ffffffff81a06ec0,3000000010) at mainbus_attach+0x70
    config_attach(8,1001000,805f50,1000000,ffffffff81a00008,0) at config_attach+0x1d2
    cpu_configure(8,1001000,ffffffff814f3859,ffffffff81a06f20,8,1001000) at cpu_configure+0x29
    main(1001000,ef0d316e102be1f4,ffffffff812e8b2f,ffffffff81a06f40,8,1001000) at main+0x3af
    end trace frame: 0x0, count: 244
    End of stack trace.

Advertise S5 as the conventional four-element package as described in the ACPI spec [1]. Cover the generated AML bytes with a unit test.

In AML, the package now looks like this:

Name (_S5, Package () {
  0x05, 0x05, 0x00, 0x00
})

Before the fix, the package looked like this:

Name (_S5, Package () {
  0x05
})

This is the first part of fixing https://github.com/cobaltcore-dev/cobaltcore/issues/577. The openbsd boot now progresses but will get stuck eventually. This is another bug though.

[1] https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/07_Power_and_Performance_Mgmt/oem-supplied-system-level-control-methods.html#sx-system-states

[phip1611]

nice find!

[amphi]

What Phips said, aside from that this looks good to me!

[phip1611]

Magnificent work!