CLI template issues: invalid engine constraints, missing CI workflow, and failing architecture checks

[Mitriyweb]

Summary by CodeRabbit

Release Notes

• New Features

  • Generated projects now include a pre-configured GitHub Actions CI workflow that automatically uses the Node.js version from .nvmrc
  • Improved architecture validation for newly scaffolded projects with Node version-aware checks

• Chores

  • Updated minimum Node.js version requirement to 24.14.0

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2cf97751-423f-4aab-96d6-975e5ee4fb14

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@architecture/DECOMPOSITION.md`:
- Around line 602-627: Update the decomposition metadata to include the new
feature: increment the total features count on Line 25 from 11 to 12 and add
cpt-frontx-feature-cli-scaffolding-quality to the Section 3 dependency
list/graph so it appears as a dependent node (ensure it links to its declared
dependency cpt-frontx-feature-cli-tooling and is represented in any bullet lists
or graph markup used in Section 3). Ensure the feature ID
cpt-frontx-feature-cli-scaffolding-quality appears in the summary/dependency
graph and that any counts or indexes elsewhere that enumerate features are
adjusted accordingly.

In `@packages/cli/src/generators/project.ts`:
- Around line 414-416: The CI workflow file was added to ROOT_CONFIG_FILES but
transformPackageManagerText is changing "npm ci" into non-deterministic
installer commands (e.g., "pnpm install" / "yarn install"); add a CI-specific
transformation that returns the lockfile-enforcing equivalents (pnpm install
--frozen-lockfile, yarn install --immutable, keep npm ci) instead of the generic
transformPackageManagerText result, implement it as a new helper (e.g.,
transformPackageManagerTextForCI or packageManagerInstallCommandCI) and update
the codepath that processes '.github/workflows/ci.yml' so it calls this
CI-specific function rather than transformPackageManagerText.

In `@packages/cli/template-sources/project/scripts/test-architecture.ts`:
- Around line 119-124: The Node version gate in test-architecture.ts currently
checks nodeVersion >= 25 which skips the arch:deps check for projects using
.nvmrc 24.x; change the condition to nodeVersion >= 24 so the checks.push({
command: runScriptCommand(packageManager, 'arch:deps'), description: 'Dependency
rules' }) branch runs for Node 24, keeping the log(...) fallback only for older
Node versions; update the numeric comparison where nodeVersion is derived from
process.versions.node.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a6655c37-f8de-441b-8a7a-87bd3dc80912

📥 Commits

Reviewing files that changed from the base of the PR and between f88fd38 and 05e1564.

⛔ Files ignored due to path filters (1)

• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (9)

• architecture/DECOMPOSITION.md
• architecture/features/feature-cli-scaffolding-quality/FEATURE.md
• package.json
• packages/cli/scripts/copy-templates.ts
• packages/cli/scripts/e2e-pr-smoke.mjs
• packages/cli/src/core/packageManager.ts
• packages/cli/src/generators/project.ts
• packages/cli/template-sources/project/configs/_github/workflows/ci.yml
• packages/cli/template-sources/project/scripts/test-architecture.ts

[GeraBart]

Review Summary

Verdict: REQUEST CHANGES — 4 blocking issues found.

1. Remove the new FEATURE document (architecture)

This PR is bug fixes + a small template enhancement, not a new feature. The scope belongs in the existing cpt-frontx-feature-cli-tooling — add CI workflow generation as a new algorithm/DoD there. Remove feature-cli-scaffolding-quality/FEATURE.md and revert the DECOMPOSITION renumbering.

2. npm ci loses lockfile enforcement (correctness)

transformPackageManagerText replaces npm ci with pnpm install / yarn install (via getInstallCommand). These don't enforce the lockfile. CI equivalents are pnpm install --frozen-lockfile and yarn install --immutable. Add a getCiInstallCommand helper or fix the existing replacement.

3. Node version gate >= 25 should be >= 24 (correctness)

Template .nvmrc is 24.14.0 (LTS). Gate at >= 25 means arch:deps is silently skipped on every generated project. Change to >= 24.

4. "hai3 create" references remain (naming)

As flagged earlier — Overview (1.1) and Actor Flow step 1 still say hai3 create. Replace with frontx create.

Recommended (non-blocking)

• Rename "HAI3 Architecture Validation" → "FrontX Architecture Validation" in test-architecture.ts:144
• Add unit tests for new transformPackageManagerText cache-key branches
• Comment explaining why generate:colors was removed from standalone checks

[GeraBart]

Re-review: ✅ APPROVE

All 4 previously raised blocking issues are resolved:

Issue	Resolution
Remove FEATURE document	✅ FEATURE.md deleted, DECOMPOSITION reverted
npm ci lockfile enforcement	✅ getCiInstallCommand added with --frozen-lockfile / --immutable
Node gate >=25 → >=24	✅ Fixed, uses Number.parseInt
hai3 create references	✅ Fixed in presets/index.ts and types.ts; HAI3→FrontX in test-architecture.ts

No new blocking issues found. CI template actions (@v6) are valid. Code logic is sound.

Recommended (non-blocking)

1. Add unit tests for getCiInstallCommand (3 branches: npm/pnpm/yarn)
2. Add unit tests for new transformPackageManagerText cache-key regex branches
3. Comment explaining why generate:colors was removed from standalone checks

Full review: .prs/245/review.md

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud