docs: ADR-0017 peer dep version pinning via pnpm migration#229
Open
dingoatemytokens wants to merge 1 commit intocyberfabric:mainfrom
Open
docs: ADR-0017 peer dep version pinning via pnpm migration#229dingoatemytokens wants to merge 1 commit intocyberfabric:mainfrom
dingoatemytokens wants to merge 1 commit intocyberfabric:mainfrom
Conversation
Review Summary by QodoDocument ADR-0017 peer dependency pinning via pnpm migration
WalkthroughsDescription• Documents ADR-0017 decision to migrate to pnpm with workspace:* protocol • Solves peer dependency resolution issues for alpha dist-tag installations • Registers new ADR in DESIGN.md architecture drivers list • Compares three options: pnpm migration, CI script, and documentation approaches Diagramflowchart LR
A["Peer Dependency<br/>Resolution Problem"] -->|"Chosen Solution"| B["Migrate to pnpm<br/>with workspace:*"]
A -->|"Alternative 1"| C["CI Script<br/>Version Pinning"]
A -->|"Alternative 2"| D["Installation<br/>Documentation"]
B -->|"Benefits"| E["Zero-maintenance<br/>Strict hoisting<br/>Content-addressable store"]
C -->|"Drawbacks"| F["Custom code<br/>Misleading source"]
D -->|"Drawbacks"| G["Poor UX<br/>Fragile"]
File Changes1. architecture/ADR/0017-peer-dep-version-pinning.md
|
Code Review by Qodo
1. Proposed ADR in drivers
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+124
to
+125
| `cpt-hai3-adr-two-tier-cli-e2e-verification`, | ||
| `cpt-hai3-adr-peer-dep-version-pinning` |
There was a problem hiding this comment.
1. Proposed adr in drivers 🐞 Bug ⚙ Maintainability
architecture/DESIGN.md lists cpt-hai3-adr-peer-dep-version-pinning among architecture driver ADRs even though ADR-0017 is still marked status: proposed, which can mislead readers into treating an unratified decision as accepted. Either mark ADR-0017 as accepted (if this decision is finalized) or remove it from the drivers list until it is accepted.
Agent Prompt
### Issue description
`architecture/DESIGN.md` lists `cpt-hai3-adr-peer-dep-version-pinning` as an architecture driver, but ADR-0017 is still marked `status: proposed`. This makes the architecture drivers list inconsistent with ADR governance and may be interpreted as an accepted decision.
### Issue Context
All other ADRs referenced in the DESIGN.md driver list are marked `status: accepted`.
### Fix Focus Areas
- architecture/DESIGN.md[124-125]
- architecture/ADR/0017-peer-dep-version-pinning.md[1-4]
### Expected fix
Choose one:
1) If the decision is finalized: change ADR-0017 frontmatter to `status: accepted`.
2) If still under review: remove `cpt-hai3-adr-peer-dep-version-pinning` from the DESIGN.md ADR drivers list until acceptance.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Documents the decision to migrate from npm to pnpm using workspace:* protocol to fix incompatible peer dependency resolution when installing @hai3/* packages from the alpha dist-tag. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: dingoatemytokens <dingoatemytokens@gmail.com>
dingoatemytokens
force-pushed
the
feature/pnpm
branch
from
2cbcadd to
ee0049c
Compare
getahead
approved these changes
Mar 26, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the decision to migrate to pnpm with workspace:* protocol to fix incompatible peer dependency resolution when installing from the alpha dist-tag. Registers the new ADR in DESIGN.md drivers.