fix: handle absence of Cargo.toml in metadata retrieval#21
fix: handle absence of Cargo.toml in metadata retrieval#21Bechma merged 1 commit intocyberfabric:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughTwo small changes: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@crates/module-parser/src/metadata.rs`:
- Line 54: The guard that checks for a manifest currently uses
path.join("Cargo.toml").exists(), which treats a directory named Cargo.toml as
valid; change this to use path.join("Cargo.toml").is_file() so the code only
proceeds when the manifest is an actual file. Update the expression in
metadata.rs where the manifest guard is performed (the code using the path
variable and "Cargo.toml") to call is_file() instead of exists(), preserving the
surrounding control flow and error handling.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 16abdd66-5760-4584-afc2-d7668b7292c9
📒 Files selected for processing (2)
crates/module-parser/src/metadata.rscrates/module-parser/src/source.rs
Signed-off-by: Bechma <19294519+Bechma@users.noreply.github.com>
e9a33dc to
5596a38
Compare
Summary by CodeRabbit