fix: Replace telemetry button with valid firmware CLI command#79
Conversation
The quick command buttons (status, ver, neighbors, help, log) were guesses that don't match actual MeshCore repeater firmware commands. Replaced with the set from the official app: neighbors, telemetry, reboot, ver. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… command) The MeshCore repeater firmware doesn't accept "telemetry" as a CLI text command — the official app uses binary protocol requests for that. Replaced with "get repeat" which maps to the official app's Repeat Settings feature and is a valid firmware CLI command. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e23a568ac2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ), | ||
| "clock": "Device time: 2025-04-15 14:32:07 UTC\nUptime: 3d 14h 22m", | ||
| "advert": "Advertisement sent (flood)", | ||
| "get repeat": "repeat: ON", |
There was a problem hiding this comment.
MOCK_CLI_RESPONSES now stores "get repeat", but MockMeshcoreClient.send_repeater_command() only looks up the first token (command.strip().split()[0].lower()). In mock mode, pressing the new quick button sends get repeat and resolves key get, so the intended mock output (repeat: ON) is never returned and developers see the generic fallback instead, reducing parity with real repeater behavior during UI testing.
Useful? React with 👍 / 👎.
The mock client only looked up the first token of a repeater command, so multi-word keys like "get repeat" in MOCK_CLI_RESPONSES never matched. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…epeat Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 participant
Summary
telemetryquick button withget repeat— telemetry is not a valid MeshCore repeater CLI command (the official app uses binary protocol requests for it)get repeatmaps to the official app's "Repeat Settings" feature and is a verified firmware CLI commandContext
Tested against a live repeater (Lafayette [rdumesh.org] running v1.12.0).
telemetryreturned "Unknown command". Verified valid commands against C++ firmware source atsrc/helpers/CommonCLI.cpp.Test plan
neighbors,get repeat,reboot,ver) return valid responses🤖 Generated with Claude Code