Skip to content

Football - add/expose Point Breakdowns on Player/BoxPlayer#665

Merged
cwendt94 merged 1 commit intocwendt94:masterfrom
jessedp:extended_stats
Oct 13, 2025
Merged

Football - add/expose Point Breakdowns on Player/BoxPlayer#665
cwendt94 merged 1 commit intocwendt94:masterfrom
jessedp:extended_stats

Conversation

@jessedp
Copy link
Contributor

@jessedp jessedp commented Sep 11, 2025

problem: Currently you can access BoxPlayer.stats[].breakdown and projected_breakdown , but that's awkward and they are the real-world stats (# of yards, # of attempts) not fantasy stats (ppr, points per yardage bucket). The points breakdown also were not accessible via Player.

fix: add points_breakdown and projected_points_breakdown to Player.stats; make breakdown, points_breakdown, projected_breakdown, projected_points_breakdown top level attributes on BoxPlayer. Would have like to just make BoxPlayer.stats = Player.stats, but don't want to break backwards compatibility.

@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.26%. Comparing base (02fec55) to head (e8349ba).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
+ Coverage   71.19%   71.26%   +0.06%     
==========================================
  Files          62       62              
  Lines        2368     2373       +5     
==========================================
+ Hits         1686     1691       +5     
  Misses        682      682              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jessedp
Copy link
Contributor Author

jessedp commented Sep 11, 2025

This may be similar to or help with what #656 is trying to do? Or maybe they didn't get to the statSourceId check and "dynamic" field layout in player.py?
Note that the functional test I've provided is pulling the test league from 2019 (which I might add test data from).

@cwendt94 cwendt94 merged commit 98f570e into cwendt94:master Oct 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants