Football - add/expose Point Breakdowns on Player/BoxPlayer#665
Merged
cwendt94 merged 1 commit intocwendt94:masterfrom Oct 13, 2025
Merged
Football - add/expose Point Breakdowns on Player/BoxPlayer#665cwendt94 merged 1 commit intocwendt94:masterfrom
cwendt94 merged 1 commit intocwendt94:masterfrom
Conversation
more top-level stats on BoxPlayer
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #665 +/- ##
==========================================
+ Coverage 71.19% 71.26% +0.06%
==========================================
Files 62 62
Lines 2368 2373 +5
==========================================
+ Hits 1686 1691 +5
Misses 682 682 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
This may be similar to or help with what #656 is trying to do? Or maybe they didn't get to the statSourceId check and "dynamic" field layout in player.py? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem: Currently you can access BoxPlayer.stats[].breakdown and projected_breakdown , but that's awkward and they are the real-world stats (# of yards, # of attempts) not fantasy stats (ppr, points per yardage bucket). The points breakdown also were not accessible via Player.
fix: add points_breakdown and projected_points_breakdown to Player.stats; make breakdown, points_breakdown, projected_breakdown, projected_points_breakdown top level attributes on BoxPlayer. Would have like to just make BoxPlayer.stats = Player.stats, but don't want to break backwards compatibility.