Skip to content
This repository was archived by the owner on Aug 29, 2022. It is now read-only.

Default SYNC_PREFER=newer#14

Open
normanlolx wants to merge 1 commit into
cweagans:masterfrom
normanlolx:patch-2
Open

Default SYNC_PREFER=newer#14
normanlolx wants to merge 1 commit into
cweagans:masterfrom
normanlolx:patch-2

Conversation

@normanlolx

@normanlolx normanlolx commented Feb 5, 2018

Copy link
Copy Markdown
Contributor

It seems confusing for some folks (and me) that after the initial sync the ongoing sync is only unidirectional (container to host only). Let's make it bidirectional by default. Refs #2

@normanlolx normanlolx changed the title Default prefer=newer Default SYNC_PREFER=newer Feb 5, 2018
@normanlolx

Copy link
Copy Markdown
Contributor Author

Interestingly EugenMayer's docker-sync has decided to prefer the host: EugenMayer/docker-sync#108

@cweagans

cweagans commented Feb 6, 2018

Copy link
Copy Markdown
Owner

I clarified this in the other issue, but just to restate it here: the sync is not unidirectional by default. Unison syncs in both directions, and if it's not, something else is wrong. Also, the current default is to prefer $SYNC_SOURCE for conflict resolutions, which should be the host FS (as in eugenmayer's docker-sync).

@normanlolx

Copy link
Copy Markdown
Contributor Author

@cweagans I guess this makes this PR unnecessary then. The problem then must be something else I guess.

@cweagans

cweagans commented Feb 6, 2018

Copy link
Copy Markdown
Owner

I think newer is more sane default, actually. I just need to do some testing and try to break it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants