Skip to content

Rules not_simplify and or_simplify#13

Merged
Mallku2 merged 5 commits intocvc5:mainfrom
Mallku2:fixpoint_rules
Mar 10, 2026
Merged

Rules not_simplify and or_simplify#13
Mallku2 merged 5 commits intocvc5:mainfrom
Mallku2:fixpoint_rules

Conversation

@Mallku2
Copy link
Copy Markdown
Collaborator

@Mallku2 Mallku2 commented Jan 28, 2026

This PR is focused on the rules not_simplify and or_simplify:

  • Mechanizes both rules.
  • Includes a test suite for both rules.
  • Misc.:
    • Minor fix in names of previous tests for eq_symmetric.
    • Continues with the slow refactoring of code, putting rules that introduce tautologies in one place, separated from the rest (moves rule eq_symmetric out of alethe.eo; adds the new rules in that new module)

Comment thread signature/rules/tautologies.eo Outdated
; return: >
; The result from applying one of the following equivalence-preserving
; transformations:
; - ⊥∨ 𝜑 ∨ ⋯ ⇒ 𝜑 ∨ ⋯
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
; - ⊥∨ 𝜑 ∨ ⋯ ⇒ 𝜑 ∨ ⋯
; - ⊥ ∨ 𝜑 ∨ ⋯ ⇒ 𝜑 ∨ ⋯

Comment thread signature/rules/tautologies.eo
Comment thread signature/rules/tautologies.eo Outdated
Comment thread tests/rules/tests_tautologies.eo Outdated
Comment thread tests/rules/tests_tautologies.eo Outdated
Comment thread tests/rules/tests_tautologies.eo Outdated
Comment thread tests/rules/tests_tautologies.eo Outdated
Comment thread tests/rules/tests_tautologies.eo Outdated
Comment thread tests/rules/tests_tautologies.eo Outdated
@hansjoergschurr
Copy link
Copy Markdown
Collaborator

Overall looks good, some suggests about the comments

@Mallku2
Copy link
Copy Markdown
Collaborator Author

Mallku2 commented Mar 10, 2026

I addressed every observation made.

@Mallku2 Mallku2 merged commit 130fa1d into cvc5:main Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants