CDP-6131: make triggerBroadcast data and recipients params optional#217
Closed
talon-github-manager[bot] wants to merge 1 commit into
Closed
CDP-6131: make triggerBroadcast data and recipients params optional#217talon-github-manager[bot] wants to merge 1 commit into
talon-github-manager[bot] wants to merge 1 commit into
Conversation
|
Closing in favor of #220, which covers the same fix and additionally omits empty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
dataandrecipientsparameters optional intriggerBroadcast(), matching the documented API in the README. When recipients is empty or omitted, the payload no longer includes an emptyrecipientskey (which caused a 422 from the API).Autonomous fix by Baloo.
Related Issues
https://linear.app/customerio/issue/CDP-6131
Testing
Deployment
Standard deployment. This change can be safely reverted.
Factory Critic Scores
Note
Low Risk
Small SDK request-shape fix for broadcast triggers; behavior for non-empty recipients is preserved and covered by existing and new tests.
Overview
Makes
dataandrecipientsoptional onAPIClient.triggerBroadcast()(defaults to{}), so callers can trigger with only a broadcast id or with template data and no recipient selector.When
recipientsis omitted or empty, the POST body is{ data }only—it no longer includes an emptyrecipientskey, which was causing 422 responses from the API. Segment-style and special-field recipient payloads are unchanged whenrecipientshas content.Adds unit tests for id-only, id + data, and explicit empty
recipients.Reviewed by Cursor Bugbot for commit 8635a7e. Bugbot is set up for automated code reviews on this repo. Configure here.