Skip to content

Remove incorrect or too restrictive validations #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sveinse merged 3 commits into from
Nov 9, 2025
Merged

Remove incorrect or too restrictive validations #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5486ca
Remove validation of ChargerLocalSettings-response
steinmn Nov 6, 2025
bce4180
Add bullet-point draft for next version
steinmn Nov 6, 2025
cffc5ea
Remove AuthenticationType requirement from Installation-validation
steinmn Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## 0.8.6 (draft)

This is a minor release that fixes a validation issue that caused the integration to stop working for users with at least one charger they only have the User role for.

In addition, it also fixes an issue where calls to the localSettings-API triggered an error on validating the response.

## 0.8.5

This is a minor release that fixes a bug in the setting of the Min/Max current of a charger.
Expand Down
17 changes: 1 addition & 16 deletions custom_components/zaptec/zaptec/validate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ class Installation(BaseModel):
model_config = ConfigDict(extra="allow")
Id: str
Active: bool
AuthenticationType: int
CurrentUserRoles: int
InstallationType: int
NetworkType: int
Expand Down Expand Up @@ -88,20 +87,6 @@ class ChargerFirmware(BaseModel):
IsUpToDate: bool


class ChargerLocalSettings(BaseModel):
"""
Pydantic model for the local settings of a Zaptec charger.

Note: This model is used in an undocumented API-call, and should be removed as soon as we have
official API-calls that can cover the necessary functionality
"""

model_config = ConfigDict(extra="allow")
Id: str
Name: str | None = None
DeviceId: str | None = None


class InstallationConnectionDetails(BaseModel):
"""Pydantic model for the servicebus connection details of a Zaptec installation."""

Expand Down Expand Up @@ -136,7 +121,7 @@ class InstallationConnectionDetails(BaseModel):
r"chargers/[0-9a-f\-]+/state": CHARGER_STATES,
r"chargers/[0-9a-f\-]+/authorizecharge": None,
r"chargers/[0-9a-f\-]+/SendCommand/[0-9]+": None,
r"chargers/[0-9a-f\-]+/localSettings": ChargerLocalSettings,
r"chargers/[0-9a-f\-]+/localSettings": None,
r"chargers/[0-9a-f\-]+/update": None,
r"chargerFirmware/installation/[0-9a-f\-]+": CHARGER_FIRMWARES,
}
Expand Down
Loading