Skip to content

Fix Playwright best practices and command correctness#3

Merged
agoldis merged 6 commits intocurrents-dev:mainfrom
elaichenkov:main
Feb 18, 2026
Merged

Fix Playwright best practices and command correctness#3
agoldis merged 6 commits intocurrents-dev:mainfrom
elaichenkov:main

Conversation

@elaichenkov
Copy link
Contributor

What changed

  • Fixed invalid test.use placement in the mobile example.

  • Replaced weak API assertion with await expect(response).toBeOK().

  • Reworked the network-wait example to avoid race conditions (waitForResponse registered before click, stricter predicate).

  • Replaced waitForNavigation() examples with waitForURL().

  • Clarified role locator name matching:

    • exact match with { exact: true }
    • flexible regex match example
  • Updated debugging docs:

    • removed misleading CLI usage
    • clarified slowMo usage in config
  • Removed invalid CLI examples (e.g. project exclusion syntax, --headed=false).

  • Fixed async rejection assertion example to:

    • await expect(asyncFn()).rejects.toThrow().

@agoldis agoldis merged commit 1ffecaa into currents-dev:main Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments