Fix Playwright best practices and command correctness#3
Merged
agoldis merged 6 commits intocurrents-dev:mainfrom Feb 18, 2026
Merged
Fix Playwright best practices and command correctness#3agoldis merged 6 commits intocurrents-dev:mainfrom
agoldis merged 6 commits intocurrents-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixed invalid
test.useplacement in the mobile example.Replaced weak API assertion with
await expect(response).toBeOK().Reworked the network-wait example to avoid race conditions (
waitForResponseregistered before click, stricter predicate).Replaced
waitForNavigation()examples withwaitForURL().Clarified role locator name matching:
{ exact: true }Updated debugging docs:
slowMousage in configRemoved invalid CLI examples (e.g. project exclusion syntax,
--headed=false).Fixed async rejection assertion example to:
await expect(asyncFn()).rejects.toThrow().