Skip to content

fix: docker.cmd annotation#92

Merged
vszakats merged 1 commit intocurl:mainfrom
jcchavezs:fix_annotation
Jan 22, 2026
Merged

fix: docker.cmd annotation#92
vszakats merged 1 commit intocurl:mainfrom
jcchavezs:fix_annotation

Conversation

@jcchavezs
Copy link
Copy Markdown
Contributor

This PR fixes the docker.cmd annotation:

➜  nuro labels curlimages/curl                                                                               ( doesn't exist)
+--------------------------------------+--------------------------------------------+
| KEY                                  | VALUE                                      |
+--------------------------------------+--------------------------------------------+
| org.opencontainers.image.licenses    | MIT                                        |
| org.opencontainers.image.source      | https://github.com/curl/curl-container     |
| version                              | 8.16.0                                     |
| docker.cmd                           | podman run -it quay.io/curl/:8.16.0        |
| io.buildah.version                   | 1.33.7                                     |
| maintainer                           | James Fuller <jim.fuller@webcomposite.com> |
| name                                 | curl-linux-386:8.16.0                      |
| org.opencontainers.image.description | minimal image for curl                     |
+--------------------------------------+--------------------------------------------+

Signed-off-by: José Carlos Chávez <jcchavezs@gmail.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the docker.cmd label annotation by replacing an undefined variable ${IMAGE_NAME_DEFAULT} with the correct variable ${image_name}. The undefined variable was causing the docker.cmd annotation to display with a missing image name (e.g., quay.io/curl/:8.16.0 instead of quay.io/curl/curl-linux-386:8.16.0).

Changes:

  • Replaced ${IMAGE_NAME_DEFAULT} with ${image_name} in the docker.cmd label configuration in both base and appliance image creation scripts

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
create_base_image.sh Fixed docker.cmd label to use the correct image_name variable instead of the undefined IMAGE_NAME_DEFAULT
create_appliance_image.sh Fixed docker.cmd label to use the correct image_name variable instead of the undefined IMAGE_NAME_DEFAULT

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vszakats vszakats merged commit db238a9 into curl:main Jan 22, 2026
8 of 9 checks passed
@vszakats
Copy link
Copy Markdown
Member

Thanks @jcchavezs, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants