Skip to content

CI: tentatively fix hypothesis version#7072

Merged
takagi merged 1 commit intocupy:masterfrom
kmaehashi:fix-hypothesis
Sep 30, 2022
Merged

CI: tentatively fix hypothesis version#7072
takagi merged 1 commit intocupy:masterfrom
kmaehashi:fix-hypothesis

Conversation

@kmaehashi
Copy link
Copy Markdown
Member

@kmaehashi kmaehashi commented Sep 30, 2022

hypothesis 65.5.0 started to infer array api spec version from __array_api_version__ attribute. https://github.com/HypothesisWorks/hypothesis/releases/tag/hypothesis-python-6.55.0
This broke the CI so until we decide the proper value for that attribute pin the hypothesis version to the previous one.

https://data-apis.org/array-api/latest/future_API_evolution.html#versioning

numpy.array_api doesn't seem to have the attribute either.

@kmaehashi
Copy link
Copy Markdown
Member Author

/test mini

@kmaehashi kmaehashi added cat:test Test code / CI to-be-backported Pull-requests to be backported to stable branch prio:high array-api Topic: Array API Standard labels Sep 30, 2022
@github-actions
Copy link
Copy Markdown

cc/ @asmeurer @leofang

@takagi takagi added this to the v12.0.0a2 milestone Sep 30, 2022
@takagi
Copy link
Copy Markdown
Contributor

takagi commented Sep 30, 2022

LGTM!

@takagi takagi merged commit 1fb6cf9 into cupy:master Sep 30, 2022
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request Sep 30, 2022
CI: tentatively fix hypothesis version
@kmaehashi kmaehashi deleted the fix-hypothesis branch September 30, 2022 08:43
@leofang
Copy link
Copy Markdown
Member

leofang commented Sep 30, 2022

Hi @honno @asmeurer is this an expected issue?

@honno
Copy link
Copy Markdown
Contributor

honno commented Sep 30, 2022

Hi @honno @asmeurer is this an expected issue?

Yep __array_api_version__ was always expected in the spec but we all forgot about it haha. Wrote a clarifying PR in data-apis/array-api#480.

For the test suite, IMO we should lean on inferring API version from this attribute going forward, and allow users to specify a version to test against. Tracked in data-apis/array-api-tests#20

Ideally you'd have __array_api_version__ = "2021.12" in your Array API namespace... we might still want to magically handle libraries without it, or at least warn on it. Hopefully going to focus on the test suite for the next few weeks generally.

@honno
Copy link
Copy Markdown
Contributor

honno commented Sep 30, 2022

Updated the test suite so it bumps Hypothesis (we need the latest version going forward) and makes libraries missing __array_api_version__ still work data-apis/array-api-tests#144. Made a release too.

@leofang
Copy link
Copy Markdown
Member

leofang commented Oct 3, 2022

Thanks, @honno!

@EarlMilktea
Copy link
Copy Markdown
Member

Any updates?

Can we safely use the latest version now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

array-api Topic: Array API Standard cat:test Test code / CI prio:high to-be-backported Pull-requests to be backported to stable branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants