Homework 5 investment calculator#6
Open
cucumberian wants to merge 6 commits into
Open
Conversation
cucumberian
commented
Aug 10, 2023
cucumberian
commented
Owner
takhanov
reviewed
Aug 20, 2023
| durationRef.current.value = ""; | ||
| }; | ||
|
|
||
| function isErrorIn(value, callbackfn, errorMessage) { |
Collaborator
There was a problem hiding this comment.
эту функцию можно вынести в utils.js и импортировать оттуда, дабы не засорять код компонента.
takhanov
reviewed
Aug 20, 2023
| const durationValue = durationRef.current.value; | ||
|
|
||
| if ( | ||
| savingsValue.trim().length === 0 || |
Collaborator
There was a problem hiding this comment.
длинную проверку тоже можно вынести в отдельную переменную, дабы не перегружать if блок. Например areAllFieldsNonEmpty.
takhanov
reviewed
Aug 20, 2023
| // Ниже приведен код для вычисления годовых результатов (общей суммы накоплений, процентов и т. д.) | ||
| let totalContributed = 0; // всего процентов | ||
| let totalSavings = currentSavings; // Всего инвестировано | ||
| for (let i = 0; i < duration; i += 1) { |
Collaborator
There was a problem hiding this comment.
данные вычисления также порекомендовал бы вынести в отдельную функцию
Collaborator
|
Все хорошо, только стоит упростить код компонентов, вынеся функции в отдельные файлы. |
takhanov
approved these changes
Aug 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.