Draft
Conversation
✅ Deploy Preview for cucumber-react-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
davidjgoss
force-pushed
the
search-rework
branch
from
d238c08 to
380298e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Previously, text search and filtering were implemented in an awkward, spread-out fashion and had several bugs.
After the move to base things around test cases in #396, we had a route to a simpler implementation for filtering. This PR achieves that, rewriting most of the plumbing, and fixes the aforementioned bugs.
⚡️ What's your motivation?
Fixes #484
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.