This repository was archived by the owner on Apr 26, 2021. It is now read-only.
Executing 'cuckoo clean' will delete directories that symlinks point to#3090
Open
soutzis wants to merge 1 commit intocuckoosandbox:masterfrom
Open
Executing 'cuckoo clean' will delete directories that symlinks point to#3090soutzis wants to merge 1 commit intocuckoosandbox:masterfrom
soutzis wants to merge 1 commit intocuckoosandbox:masterfrom
Conversation
When using `cuckoo clean`, if one of the directories under `$CWD/storage/` is a symlink, then an exception will be thrown and the files/directories that the symlink points to will not be deleted. The change here is one line of code and what it does is: - The real path of the directory (whether a regular dir or a soft link) is retrieved first and any files/directories will recursively be deleted afterwards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I have added/changed is:
One line of code.
The goal of my change is:
Enhancement closes #3086
Consider that there were more samples to be analysed than what was originally calculated and the drive of CWD is low on space. A simple solution would be to use a symlink for all analyses to be stored on a secondary drive. However, when using
$ cuckoo clean, if one of the directories under$CWD/storage/is a soft-link, then an exception will be thrown and the directory (and its contents) that the soft-link points to will not be deleted.By retrieving the real path of the directory before calling
shutils.rmtree(), this problem is easily solved and everything works as expected.What I have tested about my change is:
Before the change:
After the change:
