Allow update of chores without tasks#1309
Merged
MariusWirtz merged 1 commit intomasterfrom Jan 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the ChoreService.update() method and updates the corresponding test to use the correct test fixture. The changes address an UnboundLocalError that would occur when updating a chore with no tasks.
- Fixes
UnboundLocalErrorwhen updating chores without tasks by initializing the loop variablei - Updates test to use
chore_name3(chore without tasks) instead ofchore_name1(chore with tasks) for more accurate test coverage
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| TM1py/Services/ChoreService.py | Initializes loop variable i to prevent UnboundLocalError when iterating over empty task list |
| Tests/ChoreService_test.py | Updates test to use appropriate test fixture (chore_name3 without tasks) for testing chore updates without tasks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8f1e57a to
e0b2293
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1308