fix(pinot): support tesseract select template#11001
Open
seanm-stripe wants to merge 2 commits into
Open
Conversation
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
b64af08 to
570c9b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
Fixes #10988
Description of Changes Made (if issue reference is not provided)
This updates the Pinot
statements.selectSQL template to support Tesseract planner inputs such asfrom_prepared.Previously, Pinot overrode the base select template with an older template that only rendered
{{ from }}and{{ from_alias }}. WhenCUBEJS_TESSERACT_SQL_PLANNER=true, Tesseract can pass the source table throughfrom_prepared, which caused Pinot SQL forsql_tablecubes to render an empty subquery:The Pinot template now preserves the base select template behavior for Tesseract-facing variables, including from_prepared, while keeping Pinot’s dialect-specific OFFSET before LIMIT ordering (which is why we can't just use BaseQuery)
This also adds regression coverage for a Pinot sql_table cube using the native SQL planner to verify that generated SQL renders the table source and does not emit an empty FROM () AS clause.