docs: document request ID propagation for /v1/cubesql endpoint#10666
docs: document request ID propagation for /v1/cubesql endpoint#10666paveltiunov wants to merge 1 commit intomasterfrom
Conversation
Update REST API documentation to cover the request ID propagation feature added in commit 1bce74b (feat(api-gateway): propagate request ID for REST /cubesql endpoint). Changes: - REST API overview (index.mdx): Update 'Request span annotation' section to explicitly list both /v1/load and /v1/cubesql as supporting request span annotation, document traceparent header support, and describe the auto-generated request ID format. - REST API reference (reference.mdx): Add request span annotation note to the /v1/cubesql endpoint section explaining x-request-id and traceparent header support, and add a curl example with x-request-id header. Co-authored-by: Pavel Tiunov <pavel.tiunov@gmail.com>
|
Claude finished @paveltiunov's task in 1m 32s —— View job Review of PR #10666
Overall AssessmentThis is a clean, well-structured documentation PR. The changes accurately reflect the implementation in
Minor Issues1. Typo in The original text had this same issue, but since this paragraph was rewritten in this PR, it's a good opportunity to fix it: should be: 2. Missing The docs mention 3. Curl example (reference.mdx) — no expected response shown The other curl examples in this file show the corresponding response. The new tracing example at lines 393-399 doesn't include a response block. While the response would be the same as the basic example, including it (or a brief note like "Response format is the same as above") would be consistent with the existing documentation pattern. Positive Notes
SummaryLooks good overall — this is a straightforward docs addition that accurately documents the feature from #10633. The only actionable item is the "as whole" → "as a whole" typo fix. The other two points are optional improvements. |
Check List
Issue Reference this PR resolves
Documents the feature added in #10633 (
feat(api-gateway): propagate request ID for REST /cubesql endpoint).Description of Changes Made
The recent commit 1bce74b added request ID propagation from the HTTP request context (via
x-request-idheader,traceparentheader, or auto-generated UUID) through to the native SQL execution for the/v1/cubesqlendpoint. This PR adds documentation for this feature.Changes
REST API overview (
docs/content/product/apis-integrations/core-data-apis/rest-api/index.mdx):/v1/loadand/v1/cubesqlas endpoints that support request span annotationtraceparentheader as an alternative tox-request-id${uuid}-span-1) when no header is providedREST API reference (
docs/content/product/apis-integrations/core-data-apis/rest-api/reference.mdx):/v1/cubesqlendpoint section explaining request span annotation support withx-request-idandtraceparentheadersx-request-idheader with the/v1/cubesqlendpoint