fix(databricks-jdbc-driver): map ISODOW to DAYOFWEEK_ISO in extract template#10665
Open
jwils wants to merge 1 commit intocube-js:masterfrom
Open
fix(databricks-jdbc-driver): map ISODOW to DAYOFWEEK_ISO in extract template#10665jwils wants to merge 1 commit intocube-js:masterfrom
jwils wants to merge 1 commit intocube-js:masterfrom
Conversation
…emplate CubeSQL emits PostgreSQL-standard date parts like `isodow` for EXTRACT expressions. Spark SQL does not support `ISODOW` — the documented equivalent is `DAYOFWEEK_ISO` (Monday=1 through Sunday=7). This follows the same pattern used by BigqueryQuery, which already maps DOW → DAYOFWEEK and DOY → DAYOFYEAR. See: https://docs.databricks.com/en/sql/language-manual/functions/extract.html Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
bot
added
javascript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(e.g.
isodow) which get passed through to dialect-specific extract templatesISODOWinEXTRACT()— the documentedequivalent is
DAYOFWEEK_ISO(returns Monday=1 through Sunday=7)isodow→DAYOFWEEK_ISOmapping in the Databricks extracttemplate, following the same pattern BigqueryQuery uses for
DOW/DOYRef
rust/cubesql/cubesql/src/compile/rewrite/rules/utils.rs:130Test plan
extract(ISODOW FROM ...)via Cube SQL API producecorrect results against Databricks