feat(client-core): wire extended /v1/meta and narrow Meta types by extended flag#10625
Open
jagodin wants to merge 7 commits intocube-js:masterfrom
Open
feat(client-core): wire extended /v1/meta and narrow Meta types by extended flag#10625jagodin wants to merge 7 commits intocube-js:masterfrom
jagodin wants to merge 7 commits intocube-js:masterfrom
Conversation
… extended options
… meta options description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
Description of Changes Made
Exposes extended
/v1/metafrom@cubejs-client/corein a way that matches the API gateway (theextendedquery parameter is presence-based, so the client only sendsextended: truewhen requested and never sendsextended=false).CubeApi.meta:MetaMethodOptionswith optionalextended; request params includeextended: trueonly whenoptions.extended === true; overloads returnMeta<MetaResponse>for plain meta andMeta<MetaResponseExtended>whenextended: true.CubePlain/CubeExtended,MetaResponse/MetaResponseExtended, plain member types where extended SQL-related fields are omitted).Cuberemains an alias forCubePlain.Metais generic over the meta response type; helpers such asMetaCubeOf,CubesMapFromMeta, andTCubeMemberByTypeForMetasupport typed access.CubeApi.test.tscovers transport params for default /extended: false(noextendedkey) vsextended: true, including combinedsignalandbaseRequestId.