Skip to content

Conversation

@igorlukanin
Copy link
Member

@igorlukanin igorlukanin commented Dec 22, 2025

It will also fetch info about primary and foreign keys.

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Resolves #10228

Conversation with Claude

claude.txt

It will also fetch info about primary and foreign keys.

Resolves #10228
@igorlukanin igorlukanin requested a review from a team as a code owner December 22, 2025 11:23
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Dec 22, 2025
@igorlukanin igorlukanin requested a review from Copilot December 22, 2025 11:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the /playground/db-schema endpoint to fetch additional metadata about primary and foreign keys by switching from tablesSchema() to tablesSchemaV2().

  • Updates the dev server's database schema endpoint to use the V2 method that includes primary and foreign key information
  • Maintains backward compatibility since tablesSchemaV2() returns the same structure as tablesSchema() but with enhanced metadata

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 55.17%. Comparing base (df8161c) to head (e82f2b9).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
packages/cubejs-server-core/src/core/DevServer.ts 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (df8161c) and HEAD (e82f2b9). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (df8161c) HEAD (e82f2b9)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10275       +/-   ##
===========================================
- Coverage   83.27%   55.17%   -28.11%     
===========================================
  Files         248      221       -27     
  Lines       74448    17202    -57246     
  Branches        0     3521     +3521     
===========================================
- Hits        61999     9491    -52508     
+ Misses      12449     7216     -5233     
- Partials        0      495      +495     
Flag Coverage Δ
cube-backend 55.17% <0.00%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Database schema introspection incomplete/empty (PK/FK missing in playground/db-schema)

3 participants