Nav bar shadow #89
Merged
Nav bar shadow #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added shadow - rounded corners
… nav-bar-shadow
zachseidner1
approved these changes
Nov 12, 2025
Collaborator
zachseidner1
left a comment
zachseidner1
left a comment
There was a problem hiding this comment.
Nice job with this! Glad we finally fixed #45 . See my comment about collapsing the Surface. Also I'll do it now but make sure to link the issue to your PR next time
app/src/main/java/com/cornellappdev/score/nav/ScoreNavigationBar.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix issue #45 by adding a nav bar shadow
Changes Made
Added shadow in RootNavigation
Edited ScoreNavigationBar to round the navbar corners according to the design
Screenshots (delete if not applicable)