Pagination #88
Open
Pagination #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachseidner1
requested changes
Nov 9, 2025
Collaborator
zachseidner1
left a comment
zachseidner1
left a comment
There was a problem hiding this comment.
Thank you for fixing this up! The filtering implementation is greatly improved since your last attempt. The pagination code looks pretty reasonable as well. There's some clean up to do but I appreciate pushing this out even though you've been busy this week! Also, make sure to send the google-services.json file to the #score-android Slack channel.
app/src/main/java/com/cornellappdev/score/components/CustomRadioButton.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/ExpandableSection.kt
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/CustomRadioButton.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/CustomRadioButton.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+240
to
+244
| IconButton( | ||
| icon = painterResource(id = R.drawable.advanced_filter), | ||
| contentDescription = "Advanced filter", | ||
| onClick = onAdvancedFilterClick | ||
| ) |
Collaborator
There was a problem hiding this comment.
The filter button still looks a little large / padding seems off compared to the design (sorry design is hard to see I couldn't find this button without that overlay from the bottom sheet over top of it).
| Yours | Design |
|---|---|
 |
 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Changes Made
Test Coverage
Next Steps (delete if not applicable)
Related PRs or Issues (delete if not applicable)
Screenshots (delete if not applicable)
Screen Shot Name