Skip to content

Updated to default to "all" view on view all button click (D795) #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
droberts-ctrlo wants to merge 11 commits into from
Closed

Updated to default to "all" view on view all button click (D795) #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c097b77
Make default "all" view on view all button click on curval
droberts-ctrlo Oct 17, 2025
3047b4b
Update view name and styling
droberts-ctrlo Jan 26, 2026
223c086
Remove erroneous change
droberts-ctrlo Jan 26, 2026
75b4988
Make default "all" view on view all button click on curval
droberts-ctrlo Oct 17, 2025
856c85b
Update view name and styling
droberts-ctrlo Jan 26, 2026
a7eca6c
Remove erroneous change
droberts-ctrlo Jan 26, 2026
3924d86
Merge branch 'curval-view' of https://github.com/droberts-ctrlo/gads …
droberts-ctrlo Feb 6, 2026
118cd55
Updated curval view display name
droberts-ctrlo Feb 6, 2026
3ffa1a7
Update view name as per requirement
droberts-ctrlo Feb 6, 2026
2374cf3
Rename variables as requested
droberts-ctrlo Feb 6, 2026
b74e175
Escape values with `html` filter
droberts-ctrlo Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/GADS.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2675,13 +2675,17 @@ prefix '/:layout_name' => sub {

if (query_parameters->get('curval_record_id'))
{
my $curval = schema->resultset('Layout')->find(query_parameters->get('curval_layout_id'));
$params->{curval_layout_id} = query_parameters->get('curval_layout_id');
$params->{curval_record_id} = query_parameters->get('curval_record_id');
$params->{parent_record_id} = query_parameters->get('parent_record_id');
$params->{parent_field_name} = $curval->name;
$params->{hide_view_menu} = 1;
}

my $records = GADS::Records->new(%params);

$records->view($view);
$records->view(query_parameters->get('curval_record_id') ? undef : $view);
$records->rows($rows);
$records->page($page);
$records->sort(session 'sort');
Expand Down
2 changes: 1 addition & 1 deletion lib/GADS/API.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1092,7 +1092,7 @@ sub _get_records {
my $sheetname = param 'sheet';
my $user = logged_in_user;
my $layout = var('instances')->layout_by_shortname($sheetname); # borks on not found
my $view = current_view($user, $layout);
my $view = query_parameters->get('curval_record_id') ? undef : current_view($user, $layout);

# Allow parameters to be passed by URL query or in the body. Flatten into
# one parameters object
Expand Down
4 changes: 4 additions & 0 deletions src/frontend/css/stylesheets/base/_global.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,7 @@ table.table-bordered {
margin: 0 auto;
}
}

.text-primary {
color: $brand-secundary !important;
}
16 changes: 13 additions & 3 deletions views/navigation/records_top_bar.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,15 @@
<div class="content-block__navigation-left">
<div class="list list--horizontal">
<ul class="list__items">
[% IF hide_view_menu %]
<li class="list__item text-primary font-weight-bold">
<p>Records from field "[% parent_field_name | html %]" on record [% parent_record_id | html %]</p>
</li>
[% ELSE %]
<li class="list__item ">
[% INCLUDE navigation/dropdown_select_view.tt %]
</li>
[% END %]

<li class="list__item ">
[%
Expand Down Expand Up @@ -49,14 +55,18 @@
INCLUDE navigation/dropdown_view_limits.tt;
END;

INCLUDE navigation/dropdown_manage_views.tt;
UNLESS hide_view_menu;
INCLUDE navigation/dropdown_manage_views.tt;
END;

IF viewtype == "graph";
INCLUDE navigation/dropdown_manage_graphs.tt;
END;

INCLUDE navigation/dropdown_actions.tt;

UNLESS hide_view_menu;
INCLUDE navigation/dropdown_actions.tt;
END;

IF page == "data_timeline" AND ! layout.no_download_pdf;
INCLUDE navigation/dropdown_download_timeline.tt;
END;
Expand Down
4 changes: 2 additions & 2 deletions views/snippets/datum.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
[% ELSE %]
[% curval.links.size %]
[% END %]
row[%IF curval.links.size != 1%]s[%END%].</em>
<a href="/[% curval.parent_layout_identifier %]/data?curval_record_id=[% curval.record_id %]&curval_layout_id=[% curval.column_id %]" target="_blank">view all</a>)</p>
row[%IF curval.links.size != 1%]s[%END%].</em>|
<a href="/[% curval.parent_layout_identifier %]/data?curval_record_id=[% curval.record_id %]&curval_layout_id=[% curval.column_id %]&parent_record_id=[% cur_id %]" target="_blank">view all</a>)</p>
[% END %]
[% END %]

Expand Down